[WIP][ADD] Add account cash discount base module

[adrienpeiffer]

No description provided.

[pedrobaeza]

Isn't better account-payment repo for this module (because you can make cash-discount without SEPA modules)?

[sbidoul]

@pedrobaeza this module "just" adds basic fields to encode cash discount data on invoices. It serves as a basis for other modules, and in particular account_cash_discount_payment (#209) which lets you consider cash discount date and amount when creating payment orders, which therefore depends on account_banking_payment_export and account_cash_discount_base.

We also considered putting it in OCA/account-invoicing but that would create circular dependencies between repos.

That's why we chose to have it here to avoid creating a new repository dependency.

[pedrobaeza]

OK, I see, let's continue here then.

[laetitia-gangloff]

s/genereted/generated

[laetitia-gangloff]

I make a little test, and value of fields : "Amount Discount deducted" and "Amount Discount" are not kept when I change "Discount percent". (on Customer Invoice)
I think, this is because "Amount Discount deducted" is readonly.

[pedrobaeza]

Is this one still a WIP?

[pedrobaeza]

Is this PR and other WIP PRs of this repo still relevant? Should we close them?

[pedrobaeza]

@sbidoul is this still interesting for you or should we move to later versions?

[sbidoul]

This is running in production but we don't plan additional work on 8.0. OCA/account-payment#174 is ready for 10.0.

[pedrobaeza]

There are several pending comments and this is unreviewed, so I'm not sure if merge optimistically or what. What do you think?

[sbidoul]

@pedrobaeza we should close these PR as we will not put efforts in maintaining them.

[pedrobaeza]

Thanks for unblocking this. I close then the v8 PRs and make to get v10 ones.

P.S.: I have been pushing all my customers to v10/v11. I only have 2 with v8 that are in the way, and now I really hate v8 with the API mix and so on, but it's still a needed one for some.