[8.0][FIX] Account banking sepa credit transfer: documentation and translation updates #334
Conversation
thomaspaulb
changed the title
thomaspaulb
changed the title
| No specific configuration. | ||
| * You need to configure a valid BIC code on the banks belonging to the | ||
| source and destination bank accounts, or the export will throw a | ||
| not-so-informative 'Compute error'. | ||
|
|
There was a problem hiding this comment.
If there is such an error, we should fix it at the source of the problem instead of describing it in the README.
For a SEPA credit transfer, we do need BIC on source bank account but we don't need it any more on destination bank account, even for cross-borders wire transfer... and I think it works fine in Odoo.
There was a problem hiding this comment.
I think you are right.
After some investigation I have seen that from version 9.0 on, the whole of this module and the modules it depends on, have been refactored. Probably the error lies in this function (8.0 vs 9.0) and more specifically here. And I think it's already fixed from 9.0 onwards.
So I think the best solution would just be to backport the whole of it to 8.0, but that is a lot of effort. Alternatively, we could do with this README update, or a small bugfix in the 8.0 module. Let me see if I can do the latter quickly.
There was a problem hiding this comment.
Well, it was not that quickly, but at least I added support for the BIC being omitted (inspired by the 9.0 code) and wrote some tests. The real effort would be to backport everything, but at least this feels better than just adding a README comment.
thomaspaulb
force-pushed
the
8.0-account_banking_sepa_credit_transfer-documentation-and-translation-updates
branch
from
6d5f6f2
to
e16255c
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
I installed this module and encountered a silly spelling error in Dutch, as well as was looking for half an hour for the source of a certain "Compute error". Have fixed the spelling error and added documentation to help next users on their way.