[FIX][10.0] account_banking_mandate: onchange return value missing #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Aug 22, 2017
There was a problem hiding this comment.
Change module version according https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers
pedrobaeza
approved these changes
Aug 22, 2017
MiquelRForgeFlow
approved these changes
Aug 22, 2017
|
We can fast-track this obvious patch. |
etobella
pushed a commit
to etobella/bank-payment
that referenced
this pull request
Oct 16, 2017
etobella
pushed a commit
to etobella/bank-payment
that referenced
this pull request
Nov 9, 2017
etobella
pushed a commit
to etobella/bank-payment
that referenced
this pull request
Nov 16, 2017
sergio-teruel
pushed a commit
to Tecnativa/bank-payment
that referenced
this pull request
Nov 5, 2018
pedrobaeza
pushed a commit
to Tecnativa/bank-payment
that referenced
this pull request
Dec 13, 2018
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Feb 24, 2020
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 5, 2020
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 17, 2020
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 26, 2020
alexis-via
pushed a commit
to akretion/banking
that referenced
this pull request
Dec 23, 2020
StefanRijnhart
pushed a commit
to StefanRijnhart/bank-payment
that referenced
this pull request
Jan 8, 2021
i-vyshnevska
pushed a commit
to camptocamp/bank-payment
that referenced
this pull request
Apr 7, 2021
dnplkndll
pushed a commit
to Kencove/bank-payment
that referenced
this pull request
Oct 31, 2021
alexis-via
pushed a commit
to akretion/banking
that referenced
this pull request
Jan 4, 2022
manuelregidor
pushed a commit
to sygel-technology/bank-payment
that referenced
this pull request
Apr 7, 2022
wpichler
pushed a commit
to wpichler/bank-payment
that referenced
this pull request
Oct 25, 2022
ferran-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Dec 29, 2022
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 13, 2023
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 17, 2023
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 17, 2023
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 17, 2023
wpichler
pushed a commit
to wpichler/bank-payment
that referenced
this pull request
Jan 27, 2023
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Feb 7, 2023
wpichler
pushed a commit
to wpichler/bank-payment
that referenced
this pull request
Feb 18, 2023
hildickethan-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 6, 2023
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 13, 2023
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 21, 2023
ramiadavid
pushed a commit
to ramiadavid/bank-payment
that referenced
this pull request
Mar 2, 2024
trisdoan
pushed a commit
to trisdoan/bank-payment
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue:
Scenario
On a fresh database install module "
account". Do not install "account_banking_mandate" yet.Enable group "
A warning can be set on a partner (Account)" for the user.Open the Customer form and display the Internal Notes tab.
Set a blocking message for this customer.
Create a new invoice, set the same Customer as above, verify that the blocking message is shown.
Bug
Install module "
account_banking_mandate".Create a new invoice, set the same Customer as above, verify that the blocking message is NOT shown anymore.
Proposal
Actually the method
def _onchange_partner_id()calls the super without propagating its returned value (that returned value contains the warning message to be displayed). With this PR, the onchange method propagates the return value got from the super. As a result, the blocking message will be shown correctly.