[10.0][FIX] Don't store acc_type of res.partner.bank #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Apr 14, 2018
pedrobaeza
pushed a commit
that referenced
this pull request
Apr 14, 2018
pedrobaeza
pushed a commit
that referenced
this pull request
Apr 14, 2018
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
May 2, 2018
alexis-via
added a commit
to OCA/edi
that referenced
this pull request
May 2, 2018
mourad-ehm
pushed a commit
to akretion/banking
that referenced
this pull request
Oct 2, 2018
sergio-teruel
pushed a commit
to Tecnativa/bank-payment
that referenced
this pull request
Nov 5, 2018
antoinecln
pushed a commit
to antoinecln/bank-payment
that referenced
this pull request
Nov 23, 2018
levkar
pushed a commit
to levkar/bank-payment
that referenced
this pull request
Dec 6, 2018
mourad-ehm
pushed a commit
to akretion/banking
that referenced
this pull request
Dec 10, 2018
pedrobaeza
pushed a commit
to akretion/banking
that referenced
this pull request
Dec 13, 2018
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
joshuajan
pushed a commit
to shine-it/edi
that referenced
this pull request
Jan 5, 2019
sebalix
pushed a commit
to camptocamp/bank-payment
that referenced
this pull request
Feb 25, 2019
sebalix
pushed a commit
to camptocamp/bank-payment
that referenced
this pull request
Feb 25, 2019
lembregtse
pushed a commit
to lembregtse/bank-payment
that referenced
this pull request
Oct 1, 2019
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
rven
pushed a commit
to lembregtse/bank-payment
that referenced
this pull request
Nov 8, 2019
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Feb 10, 2020
alexis-via
added a commit
to OCA/edi
that referenced
this pull request
Feb 21, 2020
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Jun 9, 2020
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Oct 16, 2020
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
alexis-via
pushed a commit
to akretion/banking
that referenced
this pull request
Oct 16, 2020
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Nov 23, 2020
alexis-via
added a commit
to OCA/edi
that referenced
this pull request
Nov 23, 2020
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Dec 10, 2020
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Jun 16, 2021
simahawk
pushed a commit
to simahawk/edi
that referenced
this pull request
Jul 9, 2021
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Sep 3, 2021
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Oct 31, 2021
dnplkndll
pushed a commit
to Kencove/bank-payment
that referenced
this pull request
Oct 31, 2021
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Nov 24, 2021
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
jaredkipe
pushed a commit
to hibou-io/oca-bank-payment
that referenced
this pull request
Dec 15, 2021
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Dec 31, 2021
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Jan 28, 2022
fredzamoabg
pushed a commit
to fredzamoabg/bank-payment
that referenced
this pull request
Feb 2, 2022
wpichler
pushed a commit
to Callino/edi
that referenced
this pull request
Jun 29, 2022
ThomasBinsfeld
pushed a commit
to acsone/bank-payment
that referenced
this pull request
Oct 10, 2022
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Dec 26, 2022
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Mar 23, 2023
njeudy
pushed a commit
to Alusage/edi
that referenced
this pull request
May 8, 2023
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Jun 27, 2023
tafaRU
pushed a commit
to agilebg/bank-payment
that referenced
this pull request
Aug 31, 2023
tafaRU
pushed a commit
to agilebg/bank-payment
that referenced
this pull request
Aug 31, 2023
TDu
pushed a commit
to camptocamp/edi
that referenced
this pull request
Nov 22, 2023
miquelalzanillas
pushed a commit
to APSL/bank-payment
that referenced
this pull request
Nov 22, 2023
…+ fix - FIX: Don't store acc_type of res.partner.bank (OCA#467) - when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Mar 4, 2024
alexis-via
added a commit
to akretion/edi
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem due to the fact that account_payment_mode adds store=True on the native computed field acc_type of res.partner.bank
This is particularly visible when you add the module on a database with existing accounts or when you migrate from v8 to v10 for example: even if you have the module base_iban, acc_type = 'bank' on IBAN accounts. This seems to be linked to the fact that when Odoo computes+stores the initial value of the field, it doesn't take into account the inherits of the native compute method, so it will not take into account the inherit in base_iban.
There are maybe better ways to fix this (add a search method ?) ; this PR is a first proposal to address this important problem.