[Usability] mandates: search by reference, add group_by, add seq type in tree view #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,11 +68,15 @@ | |||
| <field name="model">account.banking.mandate</field> | |||
| <field name="arch" type="xml"> | |||
| <search string="Search Banking Mandates"> | |||
There was a problem hiding this comment.
Thanks for the improvements! Odd spacing here, as in the other XML. Are tabs involved, in the original or new code? Maybe this is a good time to reformat on indents of 4 spaces?
There was a problem hiding this comment.
yes, it's caused by the fact that there are tabs everywhere in the XML file !!! And the lines I added have spaces.
|
Can you please add also by type of mandate (CORE, B2B)? |
|
@pedrobaeza yes, i'll update the PR with your remark when I have 5 min |
Replace tabs by spaces in mandate views account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format
|
This PR is finished, we can merge it. Apart from the replacement of tabs by spaces, it's just a few more lines in tree+search view of mandates. No risk. |
|
All is correct as said by Alexis, so I merge. 👍 |
pedrobaeza
added a commit
that referenced
this pull request
Jan 21, 2015
[Usability] mandates: search by reference, add group_by, add seq type in tree view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.