[10.0][FIX] prevent assigning parner with default name #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-vyshnevska
force-pushed
the
10-account_bank_statement_import_camt
branch
3 times, most recently
from
f77ef30
to
2d7b427
Compare
i-vyshnevska
changed the title
| and this makes search results wrong and partner assignment randomly | ||
| """ | ||
| recordset = self | ||
| if self.env.context.get('no_reassign_empty_ref'): |
There was a problem hiding this comment.
If https://github.com/odoo/odoo/blob/c7c68bab842aba5300f3a9deec28df6e17b40559/addons/account/models/account_bank_statement.py#L328 is the update you want to avoid, maybe better do so to avoid the write altogether? (we shouldn't have more than one record in self anyway)
if (
self.env.context.get('no_reassign_empty_ref')
and len(self) == 1
and len(vals.keys()) == 1
and 'partner_id' in vals and
and self.name == '/'
):
return True
There was a problem hiding this comment.
@grindtildeath thanks, updated
i-vyshnevska
force-pushed
the
10-account_bank_statement_import_camt
branch
from
9ae7df5
to
3cb06be
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if statement has entries with empty ref (which assign to '/' in odoo) reconciliation widget cannot properly find partner_id, this PR prevents such assignment so user will see initial name given by statement