[14.0][FIX] account_statement_import_txt_xlsx: empty balance_column field #703
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexey-pelykh, |
Tiago370
force-pushed
the
fix/empty_balance_column_field
branch
2 times, most recently
from
518f194
to
44db952
Compare
|
Backport of #693 |
| @@ -61,7 +62,9 @@ def parse(self, data_file, mapping, filename): | |||
| lines = self._parse_lines(mapping, data_file, currency_code) | |||
| if not lines: | |||
| return currency_code, account_number, [{"transactions": []}] | |||
|
|
|||
| if not isinstance(lines[0]["timestamp"], datetime): | |||
There was a problem hiding this comment.
How this is related to empty balance column?
There was a problem hiding this comment.
Hello @alexey-pelykh , this line was necessary, because some banks' statements put the first line without a date, containing only the description and the previous balance, so the solution I found was to copy the date of the next line. But I'm open to suggestions, thanks for the review.
There was a problem hiding this comment.
This should be done as a separate PR. Backport is a backport, sneaky changes aren't good :)
There was a problem hiding this comment.
I understand. I will provide a new PR and fix this one.
Tiago370
force-pushed
the
fix/empty_balance_column_field
branch
from
44db952
to
50fbb8e
Compare
mileo
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the error obtained when the column cell
amount_columnis empty.