Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] [port] base_transaction_id #127

Merged
merged 10 commits into from Apr 26, 2016
Merged

[9.0] [port] base_transaction_id #127

merged 10 commits into from Apr 26, 2016

Conversation

yvaucher
Copy link
Member

No description provided.

@yvaucher yvaucher changed the title 9.0 port base transaction [9.0] [port] base_transaction_id Oct 16, 2015
@pedrobaeza pedrobaeza mentioned this pull request Oct 16, 2015
Closed
28 tasks
@yvaucher
Copy link
Member Author

lint is complaining about from opererp.osv import expression which I disagree on depreciacion

@yvaucher yvaucher mentioned this pull request Oct 16, 2015
Merged
1 task
@pedrobaeza
Copy link
Member

@yvaucher, this is only a warning. Real problems are:

base_transaction_id/models/account_move.py:37:9: F841 local variable 'prepare' is assigned to but never used
base_transaction_id/models/account_move.py:40:21: F821 undefined name 'lines'

@yvaucher
Copy link
Member Author

@pedrobaeza Thx, I fixed it.

guewen
guewen reviewed Oct 19, 2015
View reviewed changes
base_transaction_id/README.rst

* Yannick Vaucher <yannick.vaucher@camptocamp.com>
* Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com>
* Alexandre Fayolles <alexandre.fayolles@camptocamp.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Fayolles/Fayolle/

@yvaucher
Copy link
Member Author

Thx @guewen Fixed those typo

@yvaucher
Copy link
Member Author

Currently, the js inheritance needs a fixup

(it does a silent error and makes the view unloadable (blank screen with Odoo logo and top menu bar without menus))

@yvaucher
Copy link
Member Author

And we are good

@yvaucher
Copy link
Member Author

travis is not starting ?

guewen
guewen reviewed Oct 28, 2015
View reviewed changes
.travis.yml
@@ -8,9 +8,12 @@ cache: pip

addons:
apt:
sources:
- pov-wkhtmltopdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: sources is not aligned with packages

@guewen
Copy link
Member

guewen commented Oct 28, 2015

No idea why travis does not start...

@yvaucher
Copy link
Member Author

@guewen nitpicking fixed, and travis is starting this was perhaps blocking it?

@guewen
Copy link
Member

guewen commented Oct 28, 2015

👍

@yvaucher yvaucher added this to the 9.0 milestone Jan 18, 2016
@yvaucher
[PORT] base_transaction_id to 9.0
14d3373 
- Reactivate module
- move files in views and models dirs
- create README.rst from description
- make list of contributors
- remove change for invoice created on picking as it doesn't exist
anymore in Odoo Community
- move overrides in bank statement as logic moved in move lines
- adapt view inheritance to not depends on string attribute
@yvaucher
Update README.md
eafc69c
@yvaucher yvaucher force-pushed the 9.0-port-base_transaction_id branch 2 times, most recently from f46b29e to ad1991b Compare January 19, 2016 14:25
@yvaucher
Copy link
Member Author

I did some fixes and ensured last commits in 8.0 were there.

This PR is ready

leemannd
leemannd reviewed Apr 19, 2016
View reviewed changes
base_transaction_id/models/sale.py
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short header here

@leemannd
Copy link
Contributor

Nice work. Just cosmetic modifications in my comments.

leemannd
leemannd reviewed Apr 19, 2016
View reviewed changes
base_transaction_id/models/account_move.py
##############################################################################
from openerp.osv import orm, fields
from openerp import models, fields, api
from openerp.osv import expression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from openerp.models import expression ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer direct import than using an alias

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.105% when pulling 394df0d on yvaucher:9.0-port-base_transaction_id into d49003f on OCA:9.0.

@yvaucher
Copy link
Member Author

Fixed license headers

@leemannd
Copy link
Contributor

👍

@guewen guewen merged commit 3b3dff7 into OCA:9.0 Apr 26, 2016
grindtildeath pushed a commit to grindtildeath/account-reconcile that referenced this pull request Oct 16, 2019
@pedrobaeza
Merge pull request OCA#127 from Trust-Code/feature/translations
286a1cc 
Portuguese translations [8.0]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yvaucher @pedrobaeza @guewen @leemannd @coveralls @oca-transbot