Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] product_brand: remove global ACL and specify explicit routes for each line. #188

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

lef-adhoc
Copy link

See more info here: Odoo commit

@bruno-zanotti
Copy link

Hi @gurneyalex ! This is a fix to avoid the new warning introduced in Odoo v17 about ACL rules without group:
Rule product.brand.public has no group, this is a deprecated feature. Every access-granting rule should specify a group.
Can we merge?

@lef-adhoc lef-adhoc changed the title [IMP] Remove global ACL and specify explicit routes for each line. [IMP] product_brand: remove global ACL and specify explicit routes for each line. Feb 26, 2024
@lef-adhoc
Copy link
Author

Hi @sbejaoui may you check this ?

@randall-vx
Copy link

Hello @lef-adhoc

Sorry, I didn't see your MR before proceeding with mine.

Please validate this MR: #206

@bruno-zanotti
Copy link

Hi @randall-vx the new standard is to add a ACL for each user type.. so this PR is still needed, @lef-adhoc can you solve the conflicts leaving only the missing rules?

@lef-adhoc
Copy link
Author

@bruno-zanotti there I added only the missing rules

@gurneyalex
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-188-by-gurneyalex-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 141f332 into OCA:17.0 Jul 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1589852. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants