Port v8 delivery_carrier_label_gls #91

bealdav · 2016-06-20T17:39:26Z

Needs review

elicoidal · 2016-06-21T01:14:58Z

delivery_carrier_label_gls/README.rst

+++++++++++++++++++++++++++++++++++
+
+Unibox service implementation:
+- send delivery order informations and parcel infothe GLS unibox server


add an empty line before the list

a/infothe/info to the

elicoidal · 2016-06-21T01:34:01Z

@bealdav thanks for the contribution!

yvaucher · 2016-06-29T13:40:28Z

There is an error in the tests:

2016-06-22 12:56:21,035 24113 ERROR openerp_test openerp.addons.delivery_carrier_label_gls.tests.test_gls: ` openerp.exceptions.Warning: Min size for field 'outbound_depot' is 6 :  4 given

bealdav · 2016-11-12T22:03:13Z

Error with runbot AttributeError: 'Country' object has no attribute 'alpha_2'
Runbot not use the right version of pycountry (16.11.8) defined in travis.yml
I don't know why ?

bealdav · 2016-11-14T08:43:18Z

https://pypi.python.org/pypi/pycountry changes doc say:

Attribute names are more coherent now, too. Note that “alpha2”, “alpha4”, etc. are now using an underscore as that’s the pattern in the upstream packages. So it’s “alpha_2” now.

Then I switch my code to alpha_2

@gurneyalex could you tell me how ci/runbot manage versions of libs.
Does it uses travis.yml ? requirement.txt ?
How can we explain the wrong version taken account (with alpha2) ?

bealdav · 2016-11-14T08:46:20Z

@pedrobaeza you're also impacted there
https://github.com/OCA/community-data-files/blob/8.0/base_iso3166/models/res_country.py#L30-L35
FYI, your module doesn't work with the new version of the lib.

bealdav · 2016-11-15T17:30:51Z

any news @gurneyalex @yvaucher ?

gurneyalex · 2016-11-16T09:23:50Z

@bealdav @yvaucher @pedrobaeza
This is a good test. I've enabled docker build on this repository, and triggered a rebuild for this PR. Let's see if this fixes the issue.

gurneyalex · 2016-11-16T09:36:13Z

runbot is red (actually orange) because

2016-11-16 09:33:06,780 133 INFO openerp_test openerp.modules.loading: loading delivery_carrier_label_gls/demo/product.xml
2016-11-16 09:33:07,194 133 WARNING openerp_test openerp.models: stock.inventory.line.create() with unknown fields: product_uom
2016-11-16 09:33:07,220 133 WARNING openerp_test openerp.models: stock.inventory.line.create() with unknown fields: product_uom

gurneyalex · 2016-11-16T09:42:02Z

@bealdav sorry?

yvaucher · 2016-11-16T09:44:45Z

stock.inventory.line.create() with unknown fields: product_uom -> product_uom_id

https://github.com/OCA/OCB/blob/8.0/addons/stock/stock.py#L2912

bealdav · 2016-11-16T09:46:39Z

Thanks I'll push

hparfr

Minor remarks

hparfr · 2016-11-16T11:10:05Z

delivery_carrier_label_gls/models/config.py

+        string='Warehouse',
+        readonly=True, oldname='gls_warehouse',
+        help="GLS warehouse near customer location (T8700)\n"
+             "Information common to whole companies "


setting for all companies

hparfr · 2016-11-16T11:15:55Z

delivery_carrier_label_gls/models/company.py

+        help="Generate label when delivery is done")
+    gls_test = fields.Boolean(
+        string='Url Test',
+        help="Check if requested webservice is test plateform")


Use testing webservice

hparfr · 2016-11-16T11:20:03Z

delivery_carrier_label_gls/models/stock.py

+    @api.multi
+    def _get_carrier_tracking_url(self):
+        if self.carrier_id.type == 'gls':
+            res = ("https://gls-group.eu/FR/fr/suivi-colis?"


use a const

hparfr · 2016-11-16T13:40:47Z

👍

sebastienbeau · 2016-11-21T08:48:21Z

👍 ok for me too

bealdav · 2016-11-21T18:03:51Z

please @codingforfun could you review my PR above ?

bealdav · 2016-11-22T09:20:53Z

@codingforfun sorry for the inconvenient.
Now fixed.

codingforfun · 2016-11-22T09:47:44Z

THX a lot.
Sorry I hadn't the time yet for review.

Fix building project selection values

elicoidal reviewed Jun 21, 2016
View reviewed changes

bealdav mentioned this pull request Jun 22, 2016

7 gls feedback ws #57

Closed

bealdav closed this Aug 5, 2016

bealdav reopened this Aug 5, 2016

bealdav force-pushed the port-v8-gls branch from b681006 to 645db6a Compare August 5, 2016 15:28

lasley added the needs fixing label Oct 5, 2016

lasley added this to the 8.0 milestone Oct 5, 2016

bealdav force-pushed the port-v8-gls branch 3 times, most recently from d386e8d to d32302b Compare November 12, 2016 18:11

bealdav added 6 commits November 15, 2016 22:50

[PORT] gls module to v8

805736b

[FIX] gls picking and demo data

04486e1

[FIX] update to oca standard

992a9b0

[FIX] oca remarks, gls module

e336dae

[IMP] add unit test to gls carrier

8460c6e

FIX test unit in carrier_gls

cfa7887

bealdav force-pushed the port-v8-gls branch from 293d9ec to 07b1881 Compare November 15, 2016 21:53

FIX version of pycountry which breaks api

03f9cfc

bealdav force-pushed the port-v8-gls branch from 07b1881 to 03f9cfc Compare November 15, 2016 22:04

yvaucher added needs review and removed needs fixing labels Nov 16, 2016

yvaucher approved these changes Nov 16, 2016

View reviewed changes

FIX wrong field in demo data

df2c40c

alexis-via approved these changes Nov 16, 2016

View reviewed changes

hparfr approved these changes Nov 16, 2016

View reviewed changes

FIX oca typo remarks

736f1f6

sebastienbeau merged commit 8c16b2d into OCA:8.0 Nov 21, 2016

bealdav deleted the port-v8-gls branch November 21, 2016 08:48

bealdav mentioned this pull request Nov 21, 2016

EMERGENCY FIX gls module if not installed #111

Merged

vrenaville pushed a commit to camptocamp/delivery-carrier that referenced this pull request Jul 2, 2018

Merge pull request OCA#91 from yvaucher/fix-activity-selection

cb8d26f

Fix building project selection values

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port v8 delivery_carrier_label_gls #91

Port v8 delivery_carrier_label_gls #91

bealdav commented Jun 20, 2016 •

edited

Loading

elicoidal Jun 21, 2016

elicoidal Jun 21, 2016

elicoidal commented Jun 21, 2016

yvaucher commented Jun 29, 2016

bealdav commented Nov 12, 2016 •

edited

Loading

bealdav commented Nov 14, 2016

bealdav commented Nov 14, 2016

bealdav commented Nov 15, 2016

gurneyalex commented Nov 16, 2016

gurneyalex commented Nov 16, 2016

gurneyalex commented Nov 16, 2016

yvaucher commented Nov 16, 2016

bealdav commented Nov 16, 2016

hparfr left a comment

hparfr Nov 16, 2016

hparfr Nov 16, 2016

hparfr Nov 16, 2016

hparfr commented Nov 16, 2016

sebastienbeau commented Nov 21, 2016

bealdav commented Nov 21, 2016

bealdav commented Nov 22, 2016

codingforfun commented Nov 22, 2016

Port v8 delivery_carrier_label_gls #91

Port v8 delivery_carrier_label_gls #91

Conversation

bealdav commented Jun 20, 2016 • edited Loading

elicoidal Jun 21, 2016

Choose a reason for hiding this comment

elicoidal Jun 21, 2016

Choose a reason for hiding this comment

elicoidal commented Jun 21, 2016

yvaucher commented Jun 29, 2016

bealdav commented Nov 12, 2016 • edited Loading

bealdav commented Nov 14, 2016

bealdav commented Nov 14, 2016

bealdav commented Nov 15, 2016

gurneyalex commented Nov 16, 2016

gurneyalex commented Nov 16, 2016

gurneyalex commented Nov 16, 2016

yvaucher commented Nov 16, 2016

bealdav commented Nov 16, 2016

hparfr left a comment

Choose a reason for hiding this comment

hparfr Nov 16, 2016

Choose a reason for hiding this comment

hparfr Nov 16, 2016

Choose a reason for hiding this comment

hparfr Nov 16, 2016

Choose a reason for hiding this comment

hparfr commented Nov 16, 2016

sebastienbeau commented Nov 21, 2016

bealdav commented Nov 21, 2016

bealdav commented Nov 22, 2016

codingforfun commented Nov 22, 2016

bealdav commented Jun 20, 2016 •

edited

Loading

bealdav commented Nov 12, 2016 •

edited

Loading