[FIX] sale_commission: Strictly check commission type

OCA · Mar 28, 2019 · b1b275a · b1b275a
1 parent a57c666
commit b1b275a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sale_commission/__manifest__.py b/sale_commission/__manifest__.py
@@ -1,7 +1,7 @@
 # Copyright 2014-2018 Tecnativa - Pedro M. Baeza
 {
     'name': 'Sales commissions',
-    'version': '11.0.2.1.1',
+    'version': '11.0.2.1.2',
     'author': 'Tecnativa,'
               'Odoo Community Association (OCA)',
     'category': 'Sales Management',

diff --git a/sale_commission/models/sale_commission_mixin.py b/sale_commission/models/sale_commission_mixin.py
@@ -157,7 +157,7 @@ def _get_commission_amount(self, commission, subtotal, product, quantity):
             ])
         if commission.commission_type == 'fixed':
             return subtotal * (commission.fix_qty / 100.0)
-        else:
+        elif commission.commission_type == 'section':
             return commission.calculate_section(subtotal)
 
     @api.onchange('agent')