Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] trivial migration of *_unece modules #20

Merged
merged 2 commits into from
Jan 6, 2017
Merged

[ADD] trivial migration of *_unece modules #20

merged 2 commits into from
Jan 6, 2017

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Dec 29, 2016

No description provided.

@hbrunn hbrunn added this to the 9.0 milestone Dec 29, 2016
@pedrobaeza
Copy link
Member

There's no commit history nor changes in version in manifest nor README.

@hbrunn
Copy link
Member Author

hbrunn commented Dec 30, 2016

oh, seems i git checked out those modules to see how much there's todo, and then forgot to do it the right way afterwards. Thanks for the heads up!

@hbrunn hbrunn mentioned this pull request Jan 5, 2017
Closed
@pedrobaeza
Copy link
Member

@alexis-via can you review here?

pedrobaeza
pedrobaeza approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will squash a bit the commit history when merging

@alexis-via
Copy link
Contributor

I don't see the module account_payment_unece , but the title of the PR says you ported *_unece module...

@alexis-via
Copy link
Contributor

I made a minor improvement in my v10 PR ; you may like to replay this commit: 3896c05
But this can be done later.

pedrobaeza
pedrobaeza approved these changes Jan 6, 2017
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there's some big headers and outdated bug tracker links, but it doesn't worth to retain this anymore

@pedrobaeza pedrobaeza mentioned this pull request Jan 6, 2017
Closed
5 tasks
@pedrobaeza pedrobaeza merged commit 67cd8c7 into OCA:9.0 Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexis-via alexis-via alexis-via approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hbrunn @pedrobaeza @alexis-via