New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base_import_async.py #23
Conversation
fix error,python csv "delimiter" must be string, not unicode
Hey @waveyeung, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
👍 LGTM |
@waveyeung well the code looks ok, but you should sign the OCA CLA and ensure the email address you use for it is registered in your Github account. |
@waveyeung Is your fix really for 9.0? This module is un ported in 9.0 so I presume that your fix target the 8.0 branch. |
@lmignon Yes,my envirnment is 8.0. This error came from python's csv module, so this fix will also improve the project. |
@waveyeung Your PR target the 9.0 branch.
Can you do a new PR on 8.0? |
@lmignon Okay |
@rvalyi Thanks,I had sign in the http://odoo-community.org with [odoo.com] account, and my account email was not activated at that time. I have no idea about the reason. |
superseded by #24 |
Fix button visibility in proposals & membership status
fix error,python csv "delimiter" must be string, not unicode