Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base_import_async.py #23

Closed
wants to merge 2 commits into from
Closed

Update base_import_async.py #23

wants to merge 2 commits into from

Conversation

OdooMod
Copy link

@OdooMod OdooMod commented Nov 19, 2015

fix error,python csv "delimiter" must be string, not unicode

fix error,python csv "delimiter" must be string, not unicode
@oca-clabot
Copy link

Hey @waveyeung, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • @waveyeung (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

@rvalyi
Copy link
Member

rvalyi commented Nov 19, 2015

👍 LGTM

@rvalyi
Copy link
Member

rvalyi commented Nov 19, 2015

@waveyeung well the code looks ok, but you should sign the OCA CLA and ensure the email address you use for it is registered in your Github account.

@lmignon
Copy link
Sponsor

lmignon commented Nov 19, 2015

@waveyeung Is your fix really for 9.0? This module is un ported in 9.0 so I presume that your fix target the 8.0 branch.

@OdooMod
Copy link
Author

OdooMod commented Nov 19, 2015

@lmignon Yes,my envirnment is 8.0. This error came from python's csv module, so this fix will also improve the project.

@lmignon
Copy link
Sponsor

lmignon commented Nov 19, 2015

@waveyeung Your PR target the 9.0 branch.

Open waveyeung wants to merge 2 commits into OCA:9.0 from waveyeung:patch-1

Can you do a new PR on 8.0?

@OdooMod
Copy link
Author

OdooMod commented Nov 19, 2015

@lmignon Okay

@OdooMod
Copy link
Author

OdooMod commented Nov 19, 2015

@rvalyi Thanks,I had sign in the http://odoo-community.org with [odoo.com] account, and my account email was not activated at that time. I have no idea about the reason.

@lmignon
Copy link
Sponsor

lmignon commented Nov 19, 2015

superseded by #24

@lmignon lmignon closed this Nov 19, 2015
@OdooMod OdooMod deleted the patch-1 branch November 19, 2015 10:46
tschanzt pushed a commit to camptocamp/connector-interfaces that referenced this pull request Mar 15, 2018
Fix button visibility in proposals & membership status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants