7.0 add file exchange #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penobject extention
…rove execution (note for v7 version we should use connector for managing the run of file document with the job)
… sql constraint for uniqueness
|
Can we discuss about the choice of the module here? #5 |
tschanzt
referenced
this pull request
in camptocamp/connector-interfaces
Mar 15, 2018
Project proposal
mpanarin
referenced
this pull request
in camptocamp/connector-interfaces
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I propose this branch as PR, before accepting it we have to discuse about refactoring it in order to avoid duplicated work see #1
The aim of this module is just to add the posibility to exchange file with external system. This work do not include the way to process the file.
1: file_document : is a queue storage of document to process (as connector include a real queue management, we should review this and discuse about the best way to refactor it)
2: file_email : is a simple module that give the posibility to extract from a mail the attachment and put it into the file-document
3: file_repository : give the posibility to upload or download file from an sftp, ftp, filesystem repository
4: abstract_task : is needed for file_document. It just add the concept of task and this task can have several cron (if you want to execute task at two specific hours of the day)
In order to avoid discution between two PR and as this work is in some way related to #1 I propose to discuse their about the architecture of the whole system