Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][IMP] multi_step_wizard: Go Back #20

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

jarroyomorales
Copy link

Allows to go to the previous step in wizards

@jarroyomorales
Copy link
Author

@guewen @alexey-pelykh Any help with the Travis error? curl: (6) Could not resolve host: cli-assets.heroku.com

@alexey-pelykh
Copy link
Contributor

@jarroyomorales just a glitch in Travis, restarting the job would do the trick

@jarroyomorales
Copy link
Author

@alexey-pelykh Thank you!

@alexey-pelykh alexey-pelykh added this to the 11.0 milestone Dec 4, 2019
@alexey-pelykh
Copy link
Contributor

Looks good to me, @jarroyomorales do you plan to make a forward-port?

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jarroyomorales
Copy link
Author

@alexey-pelykh Sure, I can do it

@alexey-pelykh
Copy link
Contributor

/ocabot merge minor

@alexey-pelykh
Copy link
Contributor

v12 is in other repo, just FYI

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-20-by-alexey-pelykh-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 4, 2019
Signed-off-by alexey-pelykh
@OCA-git-bot OCA-git-bot merged commit 3f068bc into OCA:11.0 Dec 4, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9139261. Thanks a lot for contributing to OCA. ❤️

@alexey-pelykh
Copy link
Contributor

@jarroyomorales jarroyomorales deleted the 11.0-imp-multi_step_wizard branch December 5, 2019 07:02
@Tonow-c2c
Copy link
Contributor

Hello @jarroyomorales

I have this issue :

Error:
Odoo Server ErrorTraceback (most recent call last):
  File "/odoo/src/odoo/http.py", line 651, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/odoo/src/odoo/http.py", line 310, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File "/odoo/src/odoo/tools/pycompat.py", line 87, in reraise
    raise value
  File "/odoo/src/odoo/http.py", line 693, in dispatch
    result = self._call_function(**self.params)
  File "/odoo/src/odoo/http.py", line 342, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/odoo/src/odoo/service/model.py", line 97, in wrapper
    return f(dbname, *args, **kwargs)
  File "/odoo/src/odoo/http.py", line 335, in checked_call
    result = self.endpoint(*a, **kw)
  File "/odoo/src/odoo/http.py", line 937, in __call__
    return self.method(*args, **kw)
  File "/odoo/src/odoo/http.py", line 515, in response_wrap
    response = f(*args, **kw)
  File "/odoo/src/addons/web/controllers/main.py", line 938, in call_button
    action = self._call_kw(model, method, args, {})
  File "/odoo/src/addons/web/controllers/main.py", line 926, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/odoo/src/odoo/api.py", line 689, in call_kw
    return call_kw_multi(method, model, args, kwargs)
  File "/odoo/src/odoo/api.py", line 680, in call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/odoo/external-src/connector-jira/multi_step_wizard/models/multi_step_wizard.py", line 61, in open_previous
    'No method defined for state %s' % (self.state,)
NotImplementedError: No method defined for state final

Should you add all "state_previous*" method

state_method = getattr(self, 'state_previous_%s' % (self.state,), None)

  • final
  • link_organizations

like "state_exit*"

@jarroyomorales
Copy link
Author

@Tonow-c2c Hi! Sorry for replying so late, I didnt see the comment. You have to inherit from this abstract model and then define the funcionts state_previous_ for each state but the start one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants