Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] connector_jira_tempo: Migrate to version 15.0 #82

Merged
merged 18 commits into from
Jul 25, 2022
Merged

[15.0][MIG] connector_jira_tempo: Migrate to version 15.0 #82

merged 18 commits into from
Jul 25, 2022

Conversation

sonhd91
Copy link
Contributor

@sonhd91 sonhd91 commented Jul 14, 2022

@sonhd91 sonhd91 marked this pull request as ready for review July 15, 2022 04:38
leemannd
leemannd approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving. @sonhd91 I'll merge it once @simahawk 's comments are attended

@sonhd91 sonhd91 force-pushed the 15.0-mig-connector_jira_tempo branch 3 times, most recently from 10f4e62 to 82f836d Compare July 19, 2022 15:39
@sonhd91
Copy link
Contributor Author

sonhd91 commented Jul 19, 2022 •
edited
Loading

Pre-approving. @sonhd91 I'll merge it once @simahawk 's comments are attended

Hi @leemannd, I updated branch as @simahawk suggest, please check it out

@leemannd
Copy link
Contributor

Hello @sonhd91 currently checking also the related PRs

@leemannd
Copy link
Contributor

@sonhd91 could you remove the commit dependency?

@sonhd91 sonhd91 force-pushed the 15.0-mig-connector_jira_tempo branch from 82f836d to e3603b0 Compare July 20, 2022 12:10
@sonhd91
Copy link
Contributor Author

sonhd91 commented Jul 20, 2022

@sonhd91 could you remove the commit dependency?

I removed the commit, thank

@sonhd91 sonhd91 force-pushed the 15.0-mig-connector_jira_tempo branch from e3603b0 to 1b5057b Compare July 20, 2022 14:52
simahawk and others added 18 commits July 20, 2022 21:56
@simahawk @sonhd91
[ADD] connector_jira_tempo
60ac566
@guewen @sonhd91
Fix tempo api call with actual username instead of key
87c41be 
The Jira API handles 2 ways to work with users: using the username or
the key field (but planning to migrate to anonymous accountIds).
Most of the time, the key is equal to the login, however if at some
point a login is changed, the key will always stay the same as the
original one. The Jira API handles both username and key field, but
Tempo accepts only the username.
@guewen @sonhd91
Handle 404 errors on tempo requests
51d6779 
Needs https://github.com/camptocamp/connector-jira/pull/31
@simahawk @sonhd91
Tempo: sync status, add tests
6476b47
@simahawk @sonhd91
Tempo: add hook to validate TS
8d59a63
@OCA-git-bot @sonhd91
[ADD] icon.png
d851c66
@alexey-pelykh @sonhd91
[MIG] connector_jira_tempo: Migration to 12.0
c78bb72
@OCA-git-bot @sonhd91
[UPD] README.rst
beda7ee
@alexey-pelykh @sonhd91
[ADD] connector_jira_tempo_base, connector_jira_tempo_project_role
c308484
@jcoux @sonhd91
[FIX][11.0] Fix get timesheet lines domain
6adfa0a
@OCA-git-bot @sonhd91
connector_jira_tempo 12.0.2.1.0
78f4731
@jcoux @sonhd91
[FIX][11.0] Remove enterprise related code
51eab94
@OCA-git-bot @sonhd91
connector_jira_tempo 12.0.2.1.1
f49c179
@grindtildeath @sonhd91
[IMP] connector_jira_tempo: black, isort, prettier
f2795cd
@grindtildeath @sonhd91
[MIG] connector_jira_tempo: Migration to 13.0
5495869
@OCA-git-bot @sonhd91
[UPD] README.rst
c932de7
@sonhd91
[IMP] connector_jira_tempo: black, isort, prettier
51d0279
@sonhd91
[15.0][MIG] connector_jira_tempo: Migration to 15.0
266d262
@sonhd91 sonhd91 force-pushed the 15.0-mig-connector_jira_tempo branch from 1b5057b to 266d262 Compare July 20, 2022 15:02
@sonhd91
Copy link
Contributor Author

sonhd91 commented Jul 20, 2022

@leemannd I just rebase branch, thank

@leemannd
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-82-by-leemannd-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c3432cb into OCA:15.0 Jul 25, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 69f55e0. Thanks a lot for contributing to OCA. ❤️

@sonhd91 sonhd91 mentioned this pull request Jul 28, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sonhd91 @leemannd @OCA-git-bot @simahawk @guewen @alexey-pelykh @jcoux @grindtildeath