[IMP] add product options from php serialize strings in sale line #94

bealdav · 2015-04-03T08:36:08Z

Here is the type of format

guewen · 2015-04-07T12:08:42Z

magentoerpconnect/sale.py

+                options = [elm['label'] + ': ' + elm['print_value']
+                           for elm in
+                           record['product_options']['options'].values()]
+                name += '\nOptions:\n  - ' + '\n  - '.join(options)


What about translations?

guewen · 2015-04-07T12:09:46Z

Thanks for the patch.

However, I don't want to add a hard dependency for that since it is not used by many and could be an issue for existing installation.

I propose to replace the import by:

try:
    import phpserialize
except ImportError:
    phpserialize = None

And to check if phpserialize is not None before using it.
This optional dependency being explained in the readme.

chafique-delli · 2015-04-16T15:29:20Z

Effectively as told 'Guewen', I think that it would be better to have an optionnal dependency on 'phpserialize'.
May be an option to check in the backend ?

bealdav · 2015-04-17T12:41:49Z

HI @guewen, what do you think about @chafique-delli suggestion ? What should be the default behavior ?

guewen · 2015-04-20T09:11:28Z

HI @guewen, what do you think about @chafique-delli suggestion ? What should be the default behavior ?

Hi,

No point to have an option in the backend. If the library is there, use it, otherwise just ignore the options.

bealdav · 2015-04-20T09:17:37Z

Hi @guewen, thanks but where I put options from previous mapping in case of none ?

guewen · 2015-04-20T09:50:46Z

Hi @guewen, thanks but where I put options from previous mapping in case of none ?

I noticed that the previous mapping was writing the options in a field notes which does not exist. Possibly we can just keep the previous mapping in notes in v7 so if someone use it in that way it won't change the behavior.

bealdav · 2015-04-21T10:17:54Z

@guewen I fixed it but with by resetting my commit to keep old code.
This first commit is without phpserialize, if ok, I'll modify .travis.yml to add this lib

guewen · 2015-04-21T10:24:52Z

magentoerpconnect/sale.py

@@ -521,6 +534,18 @@ def _clean_magento_items(self, resource):

        # Group the childs with their parent
        for item in resource['items']:
+            if phpserialize is None:
+                _logger.info(PHPSERIALIZE_INFO)


This log will be logged at each import, I think it would be better to log it once in the ImportError.

bealdav · 2015-04-21T10:38:12Z

@guewen I suggest to add an item in 'Technical points' to alert of phpserialize feature

guewen · 2015-04-21T11:02:28Z

@guewen I suggest to add an item in 'Technical points' to alert of phpserialize feature

Yep

guewen · 2015-04-22T12:04:58Z

Did you see the error in the tests?

2015-04-21 12:41:27,412 24044 TEST openerp_test openerp.modules.module: Traceback (most recent call last):
2015-04-21 12:41:27,412 24044 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/connector-magento/magentoerpconnect/tests/test_sale_order.py", line 112, in test_copy_quotation_delay_export_state
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `     binding = self._import_sale_order(900000691)
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/connector-magento/magentoerpconnect/tests/test_sale_order.py", line 44, in _import_sale_order
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `     backend_id, increment_id)
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/connector-magento/magentoerpconnect/unit/import_synchronizer.py", line 378, in import_record
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `     importer.run(magento_id, force=force)
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/connector-magento/magentoerpconnect/unit/import_synchronizer.py", line 206, in run
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `     self.magento_record = self._get_magento_data()
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/connector-magento/magentoerpconnect/sale.py", line 688, in _get_magento_data
2015-04-21 12:41:27,413 24044 TEST openerp_test openerp.modules.module: `     record = self._clean_magento_items(record)
2015-04-21 12:41:27,414 24044 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/connector-magento/magentoerpconnect/sale.py", line 545, in _clean_magento_items
2015-04-21 12:41:27,414 24044 TEST openerp_test openerp.modules.module: `     item[key].encode('utf-8'), decode_strings=True)
2015-04-21 12:41:27,414 24044 TEST openerp_test openerp.modules.module: ` AttributeError: 'dict' object has no attribute 'encode'

pedrobaeza · 2018-04-28T23:48:05Z

This one has conflicts and very old, so I'm closing it. If there's still interest, feel free to reopen it fixing the problems.

…n_picking [Action #8537] Export Stock-IT picking IN one time

bealdav force-pushed the 7-product-opt-in-saleline branch from 902089b to aabe8c3 Compare April 3, 2015 08:58

guewen reviewed Apr 7, 2015
View reviewed changes

[IMP] add product options from php serialize strings in sale line

124a52e

bealdav force-pushed the 7-product-opt-in-saleline branch from aabe8c3 to 124a52e Compare April 21, 2015 10:12

guewen reviewed Apr 21, 2015
View reviewed changes

[FIX] log placement and add phpserialize in travis

4c70858

pedrobaeza closed this Apr 28, 2018

jcoux pushed a commit to camptocamp/connector-magento that referenced this pull request May 14, 2019

Merge pull request OCA#94 from CharlineDumontet/3596_stockit_export_i…

81fd8bc

…n_picking [Action #8537] Export Stock-IT picking IN one time

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] add product options from php serialize strings in sale line #94

[IMP] add product options from php serialize strings in sale line #94

bealdav commented Apr 3, 2015

guewen Apr 7, 2015

guewen commented Apr 7, 2015

chafique-delli commented Apr 16, 2015

bealdav commented Apr 17, 2015

guewen commented Apr 20, 2015

bealdav commented Apr 20, 2015

guewen commented Apr 20, 2015

bealdav commented Apr 21, 2015

guewen Apr 21, 2015

bealdav commented Apr 21, 2015

guewen commented Apr 21, 2015

guewen commented Apr 22, 2015

pedrobaeza commented Apr 28, 2018

[IMP] add product options from php serialize strings in sale line #94

[IMP] add product options from php serialize strings in sale line #94

Conversation

bealdav commented Apr 3, 2015

guewen Apr 7, 2015

Choose a reason for hiding this comment

guewen commented Apr 7, 2015

chafique-delli commented Apr 16, 2015

bealdav commented Apr 17, 2015

guewen commented Apr 20, 2015

bealdav commented Apr 20, 2015

guewen commented Apr 20, 2015

bealdav commented Apr 21, 2015

guewen Apr 21, 2015

Choose a reason for hiding this comment

bealdav commented Apr 21, 2015

guewen commented Apr 21, 2015

guewen commented Apr 22, 2015

pedrobaeza commented Apr 28, 2018