Update #4
Update #4
Conversation
|
Hey @dansanti, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
@dansanti Thanks for your contribution. |
|
hi! no problem, it's ok now? |
|
lol: I was commenting on the README actually which disappeared. |
| # | ||
| ############################################################################## | ||
| {'name': 'Salesforce connector', | ||
| 'version': '0.1', |
There was a problem hiding this comment.
Please follow the guidelines from:
https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md
version: 9.0.1.0.0
|
Some fix was added in commits later than this first commits, |
| # In SalesForce you have a limited time to ask first token | ||
| # after getting conusmer code, else code becomme invalid | ||
| backend._get_token() | ||
| return ("Backend successfuly authorized you should have a new " |
There was a problem hiding this comment.
Backend successfuly authorized: you should have a new
|
if you want, i'll delete a commits, and add all in one, but references to contributors, will be removed |
|
checked some small details but no technical review. |
|
yea, but are a lot of commits that need be merged |
|
no rush: ping me when you PR it |
|
@elicoidal @dansanti For the record, I've just added this repository to the OCA's runbot, and I'm working on making the 7.0 PR green |
|
@elicoidal there was extensive review of the 7.0 version on OCA/connector-interfaces#11 |
Merge commits,
fix .travis after rebase