[16.0] Bugs and improvements in subscription_oca

[tarteo]

Just wanted to check before I create a PR if some of these are as intended.

contract/subscription_oca/models/sale_subscription.py

Line 154 in 6c900c9

subscription.action_close_subscription()

This will not actually close the subscription just open the close reason wizard.

contract/subscription_oca/wizard/close_subscription_wizard.py

Line 25 in 6c900c9

sale_subscription.active = False

Why do we archive the record here directly IMO closed subscription should be just in the closed stage not archived directly

contract/subscription_oca/models/sale_subscription_stage.py

Line 15 in 6c900c9

in_progress = fields.Boolean(string="In progress", default=False)

This field is redundant because of field type.

contract/subscription_oca/models/sale_subscription.py

Lines 156 to 160 in 6c900c9

	else:
	if subscription.date_start == today:
	subscription.action_start_subscription()
	subscription.generate_invoice()

This way we can't have "draft" subscriptions. There should by another stage before "pre".

contract/subscription_oca/models/sale_subscription.py

Line 145 in 6c900c9

subscription.recurring_next_date == today

If the cron job fails for a day subscription begin to stagnate, this should be <=

contract/subscription_oca/models/sale_subscription.py

Line 189 in 18d62d3

record.recurring_rule_boundary = True

This should be the otherway around if there is not a boundary (unlimited) this should be False not True. This is confusing.

The tests don't pass if sale_timesheet is installed.

[francesco-ooops]

Hi @tarteo , I would suggest checking also all the IMPs and FIXs made to the v14 of the module: https://github.com/OCA/contract/pulls?q=is%3Apr+is%3Aclosed+subscription_oca

[gregory-moka]

Hello
I add 1 more lack in the addon : On sale order, we are not able to define the subscription's start date.
Maybe we can detect if a product is a subscription product to display the start date field (by default, this start date is defined by confirmation date).

Another issue is linked to the access rules. For non-admin users, it's not possible to access to contact models once the addon is installed.