[16.0][IMP] subscription_oca: Various improvements #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] subscription_oca: Various improvements
tarteo
force-pushed
the
16-imp-subscription_oca
branch
from
8473c8f
to
3851561
Compare
|
Not sure why the codecov/patch check is failing because codecov says there's a positive change (+0.03%)
|
tarteo
changed the title
| def action_open_subscription(self): | ||
| self.ensure_one() | ||
| action = self.env.ref("subscription_oca.sale_subscription_action") | ||
| action = action.read()[0] |
There was a problem hiding this comment.
Please use action = self.env["ir.actions.act_window"]._for_xml_id("subscription_oca.sale_subscription_action") instead.
| def close_subscription(self, close_reason_id=False): | ||
| self.ensure_one() | ||
| self.recurring_next_date = False | ||
| closed_stage = self.env["sale.subscription.stage"].search( |
There was a problem hiding this comment.
I don't really like selection with a limit=1. Is there a mean to restrict stage selection in a better way ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes improvements mentioned here: #1057