[ADD] contract_digitized_signature #102

cubells · 2017-10-09T15:47:55Z

New module that allows to add digitized signature to contracts and send by mail.

Related: #79

lasley · 2017-10-09T16:17:22Z

Hmmmm I wonder if we need to think about integration of this against #88, which also has signature.

I'm curious though, what is the purpose of the signature field in the backend view? Is this instead for an employee to sign off on a contract completion?

cubells · 2017-10-09T16:30:41Z

This module completes these others:
https://github.com/OCA/project/tree/9.0/project_task_digitized_signature
https://github.com/OCA/stock-logistics-workflow/tree/9.0/stock_picking_digitized_signature
OCA/sale-workflow#504

The purpose is that commercial user with a tablet or similar, in customer home, shows him a document (project, sale, contract or picking) and he signs document. Company can now continue commercial flow.

cubells · 2017-10-09T16:33:51Z

Customer signature is shown in printed document too.

pedrobaeza · 2017-10-10T07:35:13Z

@lasley not everyone wants to install website part (in v11 it's not needed, but it does on v10).

@rafaelbn you can try now

pedrobaeza · 2017-10-10T11:49:18Z

@rafaelbn give your last try.

rafaelbn · 2017-10-12T00:36:25Z

Runbot says 502 Bad Gateway I cannot test it.

By the way @cubells @pedrobaeza codecov/patch — 85.71% of diff hit (target 100%)

woodbrettm · 2017-10-12T01:26:16Z

@lasley I could probs just add this module as a dependency for website_sale_contract. Most of the backend logic in website_sale_contract lies in the checkout wizard, so should not be an issue.

@cubells would it be possible to add a signature_name field to account.analytic.account? I think it would be helpful to know the name of the person that signed the contract. Would also follow what is done in website_quote.

chienandalu

Tested on runbot. Just two non blocking comments

chienandalu · 2017-10-13T09:23:14Z

contract_digitized_signature/README.rst

+
+This module is part of the OCA/web suite.
+
+Configuration


Is this section needed. It's the same instructions as in Usage

chienandalu · 2017-10-13T09:24:14Z

contract_digitized_signature/README.rst

+   changes on it.
+#. You can clear signature in any moment by clicking on the **Clear** link
+   located on the top right side of signature box.
+#. If you print Contract, signature was added to contact report .


If you print the contract the signature will be shown in the contract report.

lasley · 2017-10-13T14:47:12Z

@BMW95 - if you can easily make our module compatible with this strategy, please do it. I'd rather not have a fractured ecosystem

rafaelbn · 2017-10-15T02:31:09Z

Please @cubells could you answer to #102 (comment). Thanks!

rafaelbn

Tested functionaly in runbot 👍

cubells · 2017-10-16T08:37:02Z

@BMW95 @lasley
I added a new field signature_name

Can you retest?

lasley · 2017-10-16T20:24:17Z

contract_digitized_signature/models/account_analytic_account.py

@@ -12,6 +12,11 @@ class AccountAnalyticAccount(models.Model):
    customer_signature = fields.Binary(
        string='Customer acceptance',
    )
+    signature_name = fields.Many2one(


IMO this should be a plain text field, possibly containing a capture of the name from the partner (not sure how your workflow works). Linking a signature to a dynamic record means that the actual data can change out from underneath the legal data

Well, you shouldn't modify contacts when there are changes, but deactivate them and create new ones. The problem with the plain text is that requires to fully type it. With this, you can select directly by direct search.

@pedrobaeza - none of my customers do that, so while yeah it's the best option, it's still not a legal field.

An alternative would be to add a signatory_id column that is the relation, with an onchange to update the signature_name.

Furthermore- this creates an incompatibility with the way Odoo does it, which is the way we did it. The goal of adding this was to make our addons live in harmony. Adding this, but making it a relation, takes us further from that goal than simply not having the column

Also - to be a relation, it needs to be suffixed with _id, which is not the case with signature_name

OK, let's change it to a char field. At the end, we don't have that requirement.

lasley

Thanks @cubells. One note, non-functional change

lasley · 2017-10-18T16:53:39Z

contract_digitized_signature/models/account_analytic_account.py

+    def create(self, values):
+        contract = super(AccountAnalyticAccount, self).create(values)
+        if contract.customer_signature:
+            values = {'customer_signature': contract.customer_signature}


Can you add a test for this please?

@lasley done!

lasley · 2017-10-19T14:45:43Z

Thanks @cubells

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

[ADD] contract_digitized_signature

434ce97

cubells mentioned this pull request Oct 9, 2017

[ADD] contract_digitized_signature #79

Closed

2 tasks

pedrobaeza approved these changes Oct 10, 2017

View reviewed changes

andhit-r approved these changes Oct 10, 2017

View reviewed changes

rafaelbn added approved needs review labels Oct 12, 2017

rafaelbn added this to the 9.0 milestone Oct 12, 2017

chienandalu approved these changes Oct 13, 2017

View reviewed changes

rafaelbn approved these changes Oct 15, 2017

View reviewed changes

Correct README and add signature_name

0ef5610

lasley reviewed Oct 16, 2017

View reviewed changes

Change to char field

cd1227d

lasley approved these changes Oct 18, 2017

View reviewed changes

Improve tests to acchieve full coverage

6e44d4f

lasley merged commit 59f07d1 into OCA:9.0 Oct 19, 2017

pedrobaeza deleted the 9.0-mig-contract_digitized_signature-2 branch October 19, 2017 14:50

woodbrettm pushed a commit to LasLabs/contract that referenced this pull request Oct 25, 2017

[ADD] contract_digitized_signature (OCA#102)

5ef30b2

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

woodbrettm pushed a commit to LasLabs/contract that referenced this pull request Nov 15, 2017

[ADD] contract_digitized_signature (OCA#102)

cc96576

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

woodbrettm pushed a commit to LasLabs/contract that referenced this pull request Dec 2, 2017

[ADD] contract_digitized_signature (OCA#102)

a061788

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

cubells added a commit to Tecnativa/contract that referenced this pull request Apr 19, 2019

[ADD] contract_digitized_signature (OCA#102)

2facf79

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

cubells added a commit to Tecnativa/contract that referenced this pull request Apr 19, 2019

[ADD] contract_digitized_signature (OCA#102)

229a76a

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

cubells added a commit to cubells/contract that referenced this pull request Aug 16, 2019

[ADD] contract_digitized_signature (OCA#102)

423ee4b

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

carms-ng pushed a commit to ERPLibre/contract that referenced this pull request Oct 14, 2020

[ADD] contract_digitized_signature (OCA#102)

56422a1

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

mathben pushed a commit to TechnoLibre/contract that referenced this pull request Mar 8, 2021

[ADD] contract_digitized_signature (OCA#102)

5d8900d

* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] contract_digitized_signature #102

[ADD] contract_digitized_signature #102

cubells commented Oct 9, 2017

lasley commented Oct 9, 2017

cubells commented Oct 9, 2017

cubells commented Oct 9, 2017

pedrobaeza commented Oct 10, 2017

pedrobaeza commented Oct 10, 2017

rafaelbn commented Oct 12, 2017

woodbrettm commented Oct 12, 2017 •

edited

Loading

chienandalu left a comment

chienandalu Oct 13, 2017

chienandalu Oct 13, 2017

lasley commented Oct 13, 2017

rafaelbn commented Oct 15, 2017

rafaelbn left a comment

cubells commented Oct 16, 2017

lasley Oct 16, 2017

pedrobaeza Oct 17, 2017

lasley Oct 17, 2017

lasley Oct 17, 2017 •

edited

Loading

pedrobaeza Oct 17, 2017

cubells Oct 18, 2017

lasley left a comment

lasley Oct 18, 2017

cubells Oct 19, 2017

lasley commented Oct 19, 2017

[ADD] contract_digitized_signature #102

[ADD] contract_digitized_signature #102

Conversation

cubells commented Oct 9, 2017

lasley commented Oct 9, 2017

cubells commented Oct 9, 2017

cubells commented Oct 9, 2017

pedrobaeza commented Oct 10, 2017

pedrobaeza commented Oct 10, 2017

rafaelbn commented Oct 12, 2017

woodbrettm commented Oct 12, 2017 • edited Loading

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Oct 13, 2017

rafaelbn commented Oct 15, 2017

rafaelbn left a comment

Choose a reason for hiding this comment

cubells commented Oct 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley Oct 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Oct 19, 2017

woodbrettm commented Oct 12, 2017 •

edited

Loading

lasley Oct 17, 2017 •

edited

Loading