Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] contract_payment_mode: Migration to 17.0 #1088

Open
wants to merge 45 commits into
base: 17.0
Choose a base branch
from

Conversation

jaenbox
Copy link
Contributor

@jaenbox jaenbox commented Jun 3, 2024

Standard migration

angelmoya and others added 30 commits June 3, 2024 22:52
* Copy partner payment mode to contracts when installing
* Filter payment modes for sales
* Adding tests
Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-12.0/contract-12.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/ca/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-12.0/contract-12.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-12.0/contract-12.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/zh_CN/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-12.0/contract-12.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/de/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-12.0/contract-12.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt/
Added view for supplier contracts, respecting the domain for payment_type.
Before was showing the inbound types in the supplier payment
willer-mo and others added 14 commits June 3, 2024 22:52
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/nl/
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-16.0/contract-16.0-contract_payment_mode
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/it/
@jaenbox jaenbox mentioned this pull request Jun 3, 2024
8 tasks
@jaenbox jaenbox force-pushed the 17.0-mig-contract_payment_mode branch from 4d58079 to 10bc045 Compare June 3, 2024 21:47
@rvalyi rvalyi changed the title [17.0][MIG] contract_paymen_ mode [17.0][MIG] contract_payment_ mode Jun 3, 2024
@pedrobaeza pedrobaeza changed the title [17.0][MIG] contract_payment_ mode [17.0][MIG] contract_payment_mode: Migration to 17.0 Jun 4, 2024
@pedrobaeza
Copy link
Member

/ocabot migration contract_payment_mode

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 4, 2024
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

)

@api.onchange("partner_id")
def on_change_partner_id(self):
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to compute method could be great (and change field to compute/store/readonly=False)



@tagged("post_install", "-at_install")
class TestContractPaymentInit(odoo.tests.HttpCase):
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should not depend on HttpCase. This is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet