-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] contract_payment_mode: Migration to 17.0 #1088
Conversation
* Copy partner payment mode to contracts when installing * Filter payment modes for sales * Adding tests
in recurring invoice
Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/ca/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/zh_CN/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/de/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-12.0/contract-12.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_payment_mode/pt/
Added view for supplier contracts, respecting the domain for payment_type. Before was showing the inbound types in the supplier payment
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-16.0/contract-16.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-16.0/contract-16.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/es/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-16.0/contract-16.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/nl/
Currently translated at 100.0% (2 of 2 strings) Translation: contract-16.0/contract-16.0-contract_payment_mode Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_payment_mode/it/
4d58079
to
10bc045
Compare
/ocabot migration contract_payment_mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat
) | ||
|
||
@api.onchange("partner_id") | ||
def on_change_partner_id(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this to compute method could be great (and change field to compute/store/readonly=False)
|
||
|
||
@tagged("post_install", "-at_install") | ||
class TestContractPaymentInit(odoo.tests.HttpCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, we should not depend on HttpCase. This is not needed.
Superseded by #1116, as no answer. |
Standard migration