-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] product_contract recordset in constrains #1092
base: 14.0
Are you sure you want to change the base?
Conversation
Hi @sbejaoui, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ValidationError(_("Contract product should be service type")) | ||
for record in self: | ||
if record.is_contract and record.type != "service": | ||
raise ValidationError(_("Contract product should be service type")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ValidationError(_("Contract product should be service type")) | |
raise ValidationError(_("Contract product (%(product_name)s) should be service type", product_name=record.name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
f2ea474
to
031dadb
Compare
subscription_oca seems to be bugged: https://github.com/OCA/contract/actions/runs/9577370040/job/26405464837?pr=1092#step:8:384 |
031dadb
to
90aca03
Compare
No description provided.