Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][FIX] Sale generation doesn't create sales #141

Merged
merged 8 commits into from
Apr 1, 2018
Merged

[10.0][FIX] Sale generation doesn't create sales #141

merged 8 commits into from
Apr 1, 2018

Conversation

flotho
Copy link
Member

@flotho flotho commented Jan 12, 2018

bad method was called in the view and the _create_invoice method was not completed
@pedrobaeza , @angelmoya , thanks in advance for your review

@flotho flotho changed the title FIX : Sale generation doesn't create sales [10.0][FIX] Sale generation doesn't create sales Jan 12, 2018
pedrobaeza
pedrobaeza reviewed Jan 13, 2018
View reviewed changes
contract_sale_generation/models/account_analytic_account.py Outdated
@@ -70,7 +70,7 @@ def _create_invoice(self):
if self.type == 'invoice':
return super(AccountAnalyticAccount, self)._create_invoice()
else:
return self.env['account.invoice']
return self.env['account.invoice']._create_sale()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. It was changed because you are mixing returning models.

@flotho
Correct bad call of method
078b7cc 
Small Documentation
@angelmoya
Copy link
Member

Thanks, I forgot when create separate methods for invoice and sales.

@flotho
Copy link
Member Author

flotho commented Jan 13, 2018

@angelmoya , thanks anyway for this great module.
AFAIK, Odoo changed all its workflow for invoicing timesheet etc... starting with the sale order is definitively the best way to have a whole process correctly set either on task or pickings and of cours invoices.
Maybe we could alos add an option for using automatic sale workflow so that some part of sale order will be automatically invoiced.

@angelmoya
Copy link
Member

angelmoya commented Jan 13, 2018 via email

@flotho
Copy link
Member Author

flotho commented Jan 15, 2018

@angelmoya that was exactly what I anted to say ;-)

@pedrobaeza , any reviw possible now ?

@pedrobaeza
Copy link
Member

Travis is still red

@flotho
Copy link
Member Author

flotho commented Jan 15, 2018

@pedrobaeza , it looks like that the failure is not related to this repo : product_contract/tests/test_sale_order.py:23

@pedrobaeza
Copy link
Member

Well, main repo is green, so something in this PR is making that module to fail.

@flotho
Copy link
Member Author

flotho commented Jan 19, 2018 •
edited
Loading

Hi @pedrobaeza ,

Could you please explain me what's wrong with Travis, I can't see what could be done from my side for solving this one.

regards

pedrobaeza
pedrobaeza reviewed Jan 19, 2018
View reviewed changes
contract_sale_generation/models/account_analytic_account.py Outdated
@@ -66,6 +66,11 @@ def _prepare_sale(self):

@api.multi
def _create_invoice(self):
"""
Create invoices
@param None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be @param self: Single record of type x

@pedrobaeza
Copy link
Member

It seems to be a temporary glitch from OCB. I have restarted the job

pedrobaeza
pedrobaeza approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashing on merging

@flotho
Copy link
Member Author

flotho commented Jan 29, 2018

Hi @pedrobaeza ,

is it my responsability to squash or will it be done by github while merging ?
regards.

@flotho
Copy link
Member Author

flotho commented Jan 29, 2018

Hi @angelmoya , any chance to be reviewed on this ?

@flotho
Copy link
Member Author

flotho commented Feb 1, 2018

Hi @pedrobaeza , what is the next step for merging ?

@pedrobaeza
Copy link
Member

You need to get more reviewers. Review other PRs and ask in exchange that they review yours.

@flotho
Copy link
Member Author

flotho commented Feb 21, 2018

@angelmoya , any chance to be reviewed ?

@pedrobaeza pedrobaeza merged commit 02ce712 into OCA:10.0 Apr 1, 2018
@pedrobaeza
Copy link
Member

I have merged it although there's no other reviewer to clean up PRs and having my own review. Please collaborate next time in other reviews for raising your "personal karma".

@flotho
Copy link
Member Author

flotho commented Apr 24, 2018

Thanks @pedrobaeza , I'm starting this as much as possible !

sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Oct 31, 2018
@flotho @sbejaoui
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
7c16d25 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
sbejaoui pushed a commit to acsone/contract that referenced this pull request Oct 24, 2020
@flotho @sbejaoui
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
f833fb6 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
sbejaoui pushed a commit to acsone/contract that referenced this pull request Oct 24, 2020
@flotho @sbejaoui
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
b1c22bf 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
sbejaoui pushed a commit to acsone/contract that referenced this pull request Nov 2, 2020
@flotho @sbejaoui
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
23b1aed 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
comuniteaCustomers pushed a commit to Comunitea/contract that referenced this pull request Feb 1, 2021
@flotho @Roodin
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
b6eb618 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
mourad-ehm pushed a commit to akretion/contract that referenced this pull request Mar 9, 2021
@flotho @mourad-ehm
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
1ce31c7 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Freni-OSI pushed a commit to ursais/contract that referenced this pull request Apr 7, 2021
@flotho @Freni-OSI
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
d3ea397 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
rousseldenis pushed a commit to acsone/contract that referenced this pull request Nov 7, 2021
@flotho @rousseldenis
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
153f9d8 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
rousseldenis pushed a commit to acsone/contract that referenced this pull request Jan 26, 2022
@flotho @rousseldenis
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
6fe52a3 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
mourad-ehm pushed a commit to akretion/contract that referenced this pull request Mar 15, 2022
@flotho @mourad-ehm
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
4e36cdd 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
rousseldenis pushed a commit to acsone/contract that referenced this pull request Jun 18, 2022
@flotho @rousseldenis
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
c0078d7 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
ntsirintanis pushed a commit to sunflowerit/contract that referenced this pull request Jun 21, 2022
@flotho @ntsirintanis
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
2d26d22 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
ntsirintanis pushed a commit to sunflowerit/contract that referenced this pull request Jun 22, 2022
@flotho @ntsirintanis
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
c8452c5 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
mourad-ehm pushed a commit to akretion/contract that referenced this pull request Aug 16, 2022
@flotho @mourad-ehm
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
4fc0ccc 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
vibhascs pushed a commit to vibhascs/contract that referenced this pull request Jan 12, 2023
@flotho @vibhascs
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
7719c96 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
baguenth pushed a commit to AmetrasIntelligence/contract that referenced this pull request Jan 12, 2023
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
65d7e1c 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
baguenth pushed a commit to AmetrasIntelligence/contract that referenced this pull request Jan 12, 2023
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
a390ceb 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
baguenth pushed a commit to AmetrasIntelligence/contract that referenced this pull request Jan 12, 2023
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
9fca9f2 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
baguenth pushed a commit to AmetrasIntelligence/contract that referenced this pull request Jan 12, 2023
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
ce091d8 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
ilyasProgrammer pushed a commit to ilyasProgrammer/contract that referenced this pull request Mar 8, 2023
@flotho @ilyasProgrammer
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
9b27be4 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
OCA-git-bot pushed a commit to vibhascs/contract that referenced this pull request Mar 21, 2023
@flotho @OCA-git-bot
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
8325f14 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
ilyasProgrammer pushed a commit to ilyasProgrammer/contract that referenced this pull request Mar 30, 2023
@flotho @ilyasProgrammer
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
8a661fd 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
JesusValdez96 pushed a commit to vauxoo-dev/contract that referenced this pull request May 28, 2023
@flotho @JesusValdez96
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
978c117 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Rad0van pushed a commit to Rad0van/contract that referenced this pull request Jun 8, 2023
@flotho @Rad0van
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
781f51d 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
adasatorres pushed a commit to adasatorres/contract that referenced this pull request Jul 26, 2023
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
6f5e446 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
brian10048 pushed a commit to brian10048/contract that referenced this pull request Nov 2, 2023
@flotho @brian10048
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
4f8d19c 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Rad0van pushed a commit to Rad0van/contract that referenced this pull request Nov 9, 2023
@flotho @Rad0van
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
fc4cdef 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
brian10048 pushed a commit to brian10048/contract that referenced this pull request Dec 1, 2023
@flotho @brian10048
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
eb2c64c 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Abranes pushed a commit to Ontinet-com/contract that referenced this pull request May 6, 2024
@flotho @Abranes
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
b290dc9 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Boxnia pushed a commit to Ontinet-com/contract that referenced this pull request May 28, 2024
@flotho
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
cc994bc 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
maisim pushed a commit to maisim/contract that referenced this pull request Jun 10, 2024
@flotho @maisim
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
7d76397 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flotho @angelmoya @pedrobaeza