[11.0] [MIG] contract sale #145
Conversation
contract_sale/README.rst
Outdated
| @@ -0,0 +1,55 @@ | |||
| .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | |||
There was a problem hiding this comment.
@levkar Please update readme with png images, runbot Odoo version..
There was a problem hiding this comment.
I migrated according to the guide and there's no such thing for png images.
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0
Maybe we should update the migration guide so that this is done automatically.
There was a problem hiding this comment.
There's already a point about that:
* Update README.rst from https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst if not updated to the latest template.| ], | ||
| 'license': 'AGPL-3', | ||
| 'installable': True, | ||
| 'auto_install': True, |
There was a problem hiding this comment.
@levkar Why the autoinstall...
There was a problem hiding this comment.
I don't know. It was like that in 10.0.
There was a problem hiding this comment.
It should be that way, as this glue module is needed if you have sale installed.
|
Please squash adjacent "OCA Transbot..." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
|
Any news about this? |
levkar
force-pushed
the
11.0-mig-contract_sale
branch
from
7cf7980
to
ffe0883
Compare
|
Squash done. |
contract_sale/README.rst
Outdated
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/110/10.0 |
contract_sale/__manifest__.py
Outdated
| 'Odoo Community Association (OCA)', | ||
| 'website': 'https://github.com/OCA/contract', | ||
| 'depends': [ | ||
| 'sale_management', |
There was a problem hiding this comment.
Instead of 'sale_management', the dependency with 'sale' is enough. Could you put this to 'sale'?
pedrobaeza
force-pushed
the
11.0-mig-contract_sale
branch
from
ffe0883
to
1288557
Compare
* README by fragments * Adjusted dependency * Changed root menu XML-ID
pedrobaeza
force-pushed
the
11.0-mig-contract_sale
branch
from
1288557
to
43959bc
Compare
No description provided.