[IMP][10.0] contract: Add templating #42

lasley · 2016-11-30T23:31:45Z

This PR adds template functionality to contract.

Depends:

10.0 contract #40

rafaelbn · 2016-12-01T00:17:26Z

Hi @lasley , contracts had templates in v8, have you recover that functionality?

lasley · 2016-12-01T00:20:29Z

It seems I did, yeah. Had no idea it was a pre-existing feature 😆

rafaelbn · 2016-12-01T00:29:24Z

I ask, because we have customers in v8 using them and we will need it fits for the migration. cc @pedrobaeza

lasley · 2016-12-01T00:32:26Z

An overview of my changes:

Move most field declarations & onchanges from account.analytic.account to new model account.analytic.contract
_inherit account.analytic.contract from account.analytic.account
Add onchange on new field contract_template_id in account.analytic.account to set fields from selected account.analytic.contract

Works quite nicely and didn't take much code, I was pretty happy. Hopefully it fits migration 😉 - I can backport to 9 fairly easy.

lasley · 2016-12-01T18:49:25Z

contract/models/account_anayltic_account.py

@@ -0,0 +1,189 @@
+# -*- coding: utf-8 -*-


File name typo

* Add template functionality for contracts

lasley · 2016-12-28T21:02:14Z

Alright this is ready for review

tedsalmon

A couple changes requested :)

tedsalmon · 2017-01-11T23:23:41Z

contract/models/account_analytic_contract.py

+            ('company_id', '=', company_id)]
+        return self.env['account.journal'].search(domain, limit=1)
+
+    @api.onchange('partner_id')


partner_id is not defined as a field of this model.

tedsalmon · 2017-01-12T20:52:52Z

contract/models/account_anayltic_account.py

@@ -3,151 +3,47 @@
 # © 2014 Angel Moya <angel.moya@domatix.com>


This file is misspelled. s/account_anayltic_account.py/account_analytic_account.py

lasley · 2017-01-14T18:15:48Z

Does anyone have any thoughts on moving contracts into a subheader of its own? Right now it's under Invoicing => Sales => Contracts, but I'd like to maybe add an Invoicing => Contracts with the following:

Contracts - Same thing we have now
Invoices - Invoice view filtered to show only those generated from contracts
Templates - View for the contract templates that I added here (there's not a view right now)

pedrobaeza · 2017-01-14T18:21:27Z

I prefer to not create another "Invoices" entry. Better to have a filter like "From contracts) in the existing one.

You need to have Contracts on Sales, because salesmen are the one who manage them. About templates, I think it's better to have it under Sales > Configuration > Contracts > Templates.

lasley · 2017-01-17T19:16:18Z

contract/__manifest__.py

@@ -10,6 +10,7 @@
    'license': 'AGPL-3',
    'author': "OpenERP SA,"


Should this OpenERP SA be Odoo SA?

I'm not sure if they have switched already their legal part. They don't put author now in Odoo 10 manifests, so no clue...

Hmmm best to play it on the safe and leave it as is then. Thanks @pedrobaeza

lasley · 2017-01-17T19:53:08Z

@tedsalmon - thanks for the review

@pedrobaeza - I somewhat followed your suggestion on the menu placement. contract doesn't have any sale depenencies though, so I didn't want to bring that in just for the menu. Instead I just placed the "Contract Templates" in the Invoicing Configuration instead, which I think hits the intent well enough.

I'm torn on whether it should be above or below "Settings". I settled on below, but am definitely open to other placements.

Add template functionality for contracts

lasley mentioned this pull request Nov 30, 2016

[RFC] product_contract: Allow for the sales of contracts #43

Closed

rafaelbn added the work in progress label Dec 1, 2016

rafaelbn added this to the 10.0 milestone Dec 1, 2016

lasley commented Dec 1, 2016

View reviewed changes

contract/models/account_anayltic_account.py

@@ -0,0 +1,189 @@

# -*- coding: utf-8 -*-

Copy link

Contributor Author

lasley Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name typo

lasley force-pushed the feature/10.0/contract-template branch from 4bdb1ce to 5b3735f Compare December 5, 2016 16:58

lasley force-pushed the feature/10.0/contract-template branch from 5b3735f to 9e4a383 Compare December 20, 2016 07:09

[IMP] contract: Add templating

bde8330

* Add template functionality for contracts

lasley force-pushed the feature/10.0/contract-template branch 2 times, most recently from a269200 to 42e2907 Compare December 27, 2016 02:39

Add security for account.anayltic.invoice.line & fix lints

3d294ce

lasley force-pushed the feature/10.0/contract-template branch from 42e2907 to 3d294ce Compare December 27, 2016 02:49

Add missing test coverage

a5b026b

rafaelbn added needs review and removed work in progress labels Dec 28, 2016

tedsalmon suggested changes Jan 11, 2017

View reviewed changes

tedsalmon reviewed Jan 12, 2017

View reviewed changes

tedsalmon mentioned this pull request Jan 12, 2017

[ADD] product_contract: Create module #49

Merged

lasley commented Jan 17, 2017

View reviewed changes

lasley force-pushed the feature/10.0/contract-template branch 4 times, most recently from 6b3d02f to b08e4bb Compare January 17, 2017 20:29

sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Sep 30, 2019

[IMP][10.0] contract: Add templating (OCA#42)

3913f2f

Add template functionality for contracts

sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Sep 30, 2019

[IMP][10.0] contract: Add templating (OCA#42)

f4e474c

Add template functionality for contracts

sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Sep 30, 2019

[IMP][10.0] contract: Add templating (OCA#42)

9d4833d

Add template functionality for contracts

devCbssolutionsRo pushed a commit to devCbssolutionsRo/contract that referenced this pull request Dec 19, 2019

[IMP][10.0] contract: Add templating (OCA#42)

ccee4f6

Add template functionality for contracts

AaronHForgeFlow pushed a commit to ForgeFlow/contract that referenced this pull request Apr 24, 2020

[IMP][10.0] contract: Add templating (OCA#42)

4e68cb6

Add template functionality for contracts

pedrobaeza pushed a commit to Tecnativa/contract that referenced this pull request Jul 14, 2020

[IMP][10.0] contract: Add templating (OCA#42)

051c2b7

Add template functionality for contracts

CarlosRoca13 pushed a commit to Tecnativa/contract that referenced this pull request Oct 27, 2020

[IMP][10.0] contract: Add templating (OCA#42)

8b4849c

Add template functionality for contracts

ozono pushed a commit to ozono/contract that referenced this pull request Nov 7, 2020

[IMP][10.0] contract: Add templating (OCA#42)

1807521

Add template functionality for contracts

ozono pushed a commit to ozono/contract that referenced this pull request Nov 14, 2020

[IMP][10.0] contract: Add templating (OCA#42)

0efd90c

Add template functionality for contracts

dnplkndll pushed a commit to Kencove/contract that referenced this pull request Dec 6, 2020

[IMP][10.0] contract: Add templating (OCA#42)

cab169a

Add template functionality for contracts

ozono pushed a commit to ozono/contract that referenced this pull request Apr 2, 2021

[IMP][10.0] contract: Add templating (OCA#42)

4615a1b

Add template functionality for contracts

victoralmau pushed a commit to Tecnativa/contract that referenced this pull request Sep 23, 2021

[IMP][10.0] contract: Add templating (OCA#42)

820e0b2

Add template functionality for contracts

jcdrubay pushed a commit to jcdrubay/contract that referenced this pull request Oct 28, 2021

[IMP][10.0] contract: Add templating (OCA#42)

24d3965

Add template functionality for contracts

olgamarcocb pushed a commit to tegin/contract that referenced this pull request Nov 16, 2021

[IMP][10.0] contract: Add templating (OCA#42)

698159a

Add template functionality for contracts

olgamarcocb pushed a commit to tegin/contract that referenced this pull request Nov 16, 2021

[IMP][10.0] contract: Add templating (OCA#42)

f6a3f4d

Add template functionality for contracts

wpichler pushed a commit to wpichler/contract that referenced this pull request Oct 24, 2022

[IMP][10.0] contract: Add templating (OCA#42)

5e0ee5f

Add template functionality for contracts

victoralmau pushed a commit to Tecnativa/contract that referenced this pull request Nov 3, 2022

[IMP][10.0] contract: Add templating (OCA#42)

c7ec32c

Add template functionality for contracts

victoralmau pushed a commit to Tecnativa/contract that referenced this pull request Nov 3, 2022

[IMP][10.0] contract: Add templating (OCA#42)

d65a46f

Add template functionality for contracts

pedrobaeza pushed a commit to wpichler/contract that referenced this pull request Mar 15, 2023

[IMP][10.0] contract: Add templating (OCA#42)

30207c4

Add template functionality for contracts

heliaktiv pushed a commit to heliaktiv/contract that referenced this pull request Jun 6, 2023

[IMP][10.0] contract: Add templating (OCA#42)

3819378

Add template functionality for contracts

brian10048 pushed a commit to brian10048/contract that referenced this pull request Dec 1, 2023

[IMP][10.0] contract: Add templating (OCA#42)

fe0b017

Add template functionality for contracts

brian10048 pushed a commit to brian10048/contract that referenced this pull request Dec 1, 2023

[IMP][10.0] contract: Add templating (OCA#42)

d8cd512

Add template functionality for contracts

carolinafernandez-tecnativa pushed a commit to Tecnativa/contract that referenced this pull request Jan 5, 2024

[IMP][10.0] contract: Add templating (OCA#42)

60f8f5e

Add template functionality for contracts

carolinafernandez-tecnativa pushed a commit to Tecnativa/contract that referenced this pull request Jan 5, 2024

[IMP][10.0] contract: Add templating (OCA#42)

ae3cbbe

Add template functionality for contracts

peluko00 pushed a commit to APSL/contract that referenced this pull request Feb 15, 2024

[IMP][10.0] contract: Add templating (OCA#42)

7278752

Add template functionality for contracts

jaydeep32 pushed a commit to archeti-org/contract that referenced this pull request Feb 15, 2024

[IMP][10.0] contract: Add templating (OCA#42)

8c6b261

Add template functionality for contracts

CRogos pushed a commit to c4a8-odoo/module-oca-contract that referenced this pull request Mar 23, 2024

[IMP][10.0] contract: Add templating (OCA#42)

51fa860

Add template functionality for contracts

CRogos pushed a commit to c4a8-odoo/module-oca-contract that referenced this pull request Mar 23, 2024

[IMP][10.0] contract: Add templating (OCA#42)

bf20efb

Add template functionality for contracts

CRogos pushed a commit to c4a8-odoo/module-oca-contract that referenced this pull request Mar 23, 2024

[IMP][10.0] contract: Add templating (OCA#42)

5b30e3b

Add template functionality for contracts

juanjosesegui-tecnativa pushed a commit to Tecnativa/contract that referenced this pull request Jul 22, 2024

[IMP][10.0] contract: Add templating (OCA#42)

bb4963c

Add template functionality for contracts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP][10.0] contract: Add templating #42

[IMP][10.0] contract: Add templating #42

lasley commented Nov 30, 2016 •

edited

Loading

rafaelbn commented Dec 1, 2016 •

edited

Loading

lasley commented Dec 1, 2016

rafaelbn commented Dec 1, 2016

lasley commented Dec 1, 2016 •

edited

Loading

lasley Dec 1, 2016

lasley commented Dec 28, 2016

tedsalmon left a comment

tedsalmon Jan 11, 2017

tedsalmon Jan 12, 2017

lasley commented Jan 14, 2017 •

edited

Loading

pedrobaeza commented Jan 14, 2017

lasley Jan 17, 2017

pedrobaeza Jan 17, 2017

lasley Jan 17, 2017

lasley commented Jan 17, 2017

		@@ -3,151 +3,47 @@
		# © 2014 Angel Moya <angel.moya@domatix.com>

		@@ -10,6 +10,7 @@
		'license': 'AGPL-3',
		'author': "OpenERP SA,"

[IMP][10.0] contract: Add templating #42

[IMP][10.0] contract: Add templating #42

Conversation

lasley commented Nov 30, 2016 • edited Loading

rafaelbn commented Dec 1, 2016 • edited Loading

lasley commented Dec 1, 2016

rafaelbn commented Dec 1, 2016

lasley commented Dec 1, 2016 • edited Loading

lasley Dec 1, 2016

Choose a reason for hiding this comment

lasley commented Dec 28, 2016

tedsalmon left a comment

Choose a reason for hiding this comment

tedsalmon Jan 11, 2017

Choose a reason for hiding this comment

tedsalmon Jan 12, 2017

Choose a reason for hiding this comment

lasley commented Jan 14, 2017 • edited Loading

pedrobaeza commented Jan 14, 2017

lasley Jan 17, 2017

Choose a reason for hiding this comment

pedrobaeza Jan 17, 2017

Choose a reason for hiding this comment

lasley Jan 17, 2017

Choose a reason for hiding this comment

lasley commented Jan 17, 2017

lasley commented Nov 30, 2016 •

edited

Loading

rafaelbn commented Dec 1, 2016 •

edited

Loading

lasley commented Dec 1, 2016 •

edited

Loading

lasley commented Jan 14, 2017 •

edited

Loading