Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][10.0] contract_variable_quantity #44

Merged
merged 1 commit into from
Dec 5, 2016
Merged

[MIG][10.0] contract_variable_quantity #44

merged 1 commit into from
Dec 5, 2016

Conversation

lasley
Copy link
Contributor

@lasley lasley commented Dec 1, 2016 •
edited
Loading

Seems functional with just the standard v10 migration seds

  • Bump version
  • Change openerp references to odoo
  • Installable to True
  • Change permissions & views to accounting dependency

Depends:

@lasley lasley force-pushed the release/10.0/contract_variable_quantity branch from c435875 to 6cb2a62 Compare December 1, 2016 00:23
@lasley lasley mentioned this pull request Dec 1, 2016
Closed
8 tasks
@lasley
Copy link
Contributor Author

lasley commented Dec 1, 2016

Hah no wonder it all worked so smooth. This was already done in the original PR, just not in the title. Closing!

@lasley lasley closed this Dec 1, 2016
@lasley lasley deleted the release/10.0/contract_variable_quantity branch December 1, 2016 00:26
@lasley lasley restored the release/10.0/contract_variable_quantity branch December 1, 2016 00:29
@lasley lasley reopened this Dec 1, 2016
@lasley
Copy link
Contributor Author

lasley commented Dec 1, 2016 •
edited
Loading

Possibly too quick to close, migration is not complete in #40.

@StefanRijnhart I think best course of action would be to remove the contract_variable_quantity from the #40 and I can just finish it here. Once your's is merged, I'll git-fu it into a commit whatever work you already did here, then mine into another. Sound like a plan?

@lasley lasley force-pushed the release/10.0/contract_variable_quantity branch 2 times, most recently from 62e6dbd to 51f3da1 Compare December 1, 2016 01:01
@lasley
[MIG] contract_variable_quantity: Migrate to v10
75429db 
* Bump version
* Change openerp references to odoo
* Installable to True
* Change permissions & views to accounting dependency
@lasley lasley force-pushed the release/10.0/contract_variable_quantity branch from 51f3da1 to 75429db Compare December 5, 2016 16:57
@lasley
Copy link
Contributor Author

lasley commented Dec 5, 2016

Rebased now that depend is merged

StefanRijnhart
StefanRijnhart approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart StefanRijnhart merged commit b41bf92 into OCA:10.0 Dec 5, 2016
@lasley lasley deleted the release/10.0/contract_variable_quantity branch December 5, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasley @StefanRijnhart @pedrobaeza