Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate contract_show_invoice to v10 #54

Merged
merged 6 commits into from Mar 22, 2017
Merged

Migrate contract_show_invoice to v10 #54

merged 6 commits into from Mar 22, 2017

Conversation

thinkwelltwd
Copy link

Here's my first PR for an OCA project. I don't suppose I'll learn any younger, or find anything easier to start with!

But anyway, I could use this module and hope that these changes fit what you want to see.

@oca-clabot
Copy link

Hey @thinkwelltwd, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Dave Burkholder (no github login found)

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza mentioned this pull request Mar 21, 2017
Closed
8 tasks
@pedrobaeza
Copy link
Member

Good start as this one is easy to start with. Please sign the CLA.

pedrobaeza
pedrobaeza reviewed Mar 21, 2017
View reviewed changes
contract_show_invoice/__manifest__.py Outdated
@@ -6,7 +6,7 @@
{
'name': 'Contract Show Invoice',
'summary': 'Button in contracts to show their invoices',
'version': '9.0.1.1.0',
'version': '10.0.1.1.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restart version number with 10.0.1.0.0

@JordiBForgeFlow
Copy link
Sponsor Member

@thinkwelltwd I just processed your CLA.

lasley
lasley reviewed Mar 21, 2017
View reviewed changes
contract_show_invoice/views/contract_view.xml Outdated
@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<openerp>
<odoo>
<data>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the data tag anymore, can remove and decrease indentation level four spaces

lasley
lasley approved these changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code, no test

@thinkwelltwd
Copy link
Author

Runbot is not happy, but it's not clear to my why not. Does this init Init build environment mean it could not initialize the build?

runbot

@lasley
Copy link
Contributor

lasley commented Mar 21, 2017

@thinkwelltwd - it's actually a warning. Click the Gear Icon, then Full All Logs:

image

2017-03-21 20:58:15,923 210 WARNING openerp_test odoo.addons.base.ir.ir_model: Creating the ir.model.data menu_config_contract in module contract instead of contract_variable_quantity.

dreispt
dreispt approved these changes Mar 21, 2017
View reviewed changes
Copy link
Sponsor Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Please add your name to the contributors list on the README.

@lasley
Copy link
Contributor

lasley commented Mar 22, 2017

FYI Runbot warning is on current 10.0 too, so good to ignore

lasley
lasley reviewed Mar 22, 2017
View reviewed changes
contract_show_invoice/__manifest__.py Outdated
@@ -9,6 +10,7 @@
'version': '10.0.1.0.0',
'author': 'Domatix,'
'Tecnativa,'
'Thinkwell Designs,'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorship and copyright is a bit of an overreach for the work that was performed here. Please limit the attribution to the ReadMe in this instance

lasley
lasley reviewed Mar 22, 2017
View reviewed changes
contract_show_invoice/__manifest__.py Outdated
'author': 'Domatix,'
'Tecnativa,'
'Thinkwell Designs,'
Copy link
Contributor

@lasley lasley Mar 22, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I commented on an outdated diff, so it was collapsed. Commenting on current:

Authorship and copyright is a bit of an overreach for the work that was performed here. Please limit the attribution to the ReadMe in this instance

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. When I put that there, I wasn't aware of the README location; should have read Daniel Reis's comment better. Found it in relation to another module, so I added it there as well. But now will yank it from the manifest file.

lasley
lasley approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thinkwelltwd - congrats on your first OCA contribution 👍

pedrobaeza
pedrobaeza approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with squashing

@pedrobaeza pedrobaeza merged commit c9b1e49 into OCA:10.0 Mar 22, 2017
levkar pushed a commit to levkar/contract that referenced this pull request Feb 16, 2018
@thinkwelltwd @lk-eska
[MIG] contract_show_invoice: Migration to v10 (OCA#54)
255811e
levkar pushed a commit to levkar/contract that referenced this pull request Feb 17, 2018
@thinkwelltwd @lk-eska
[MIG] contract_show_invoice: Migration to v10 (OCA#54)
fb9901e
levkar pushed a commit to levkar/contract that referenced this pull request Feb 17, 2018
@thinkwelltwd @lk-eska
[MIG] contract_show_invoice: Migration to v10 (OCA#54)
58b5952
levkar pushed a commit to levkar/contract that referenced this pull request Feb 17, 2018
@thinkwelltwd @lk-eska
[MIG] contract_show_invoice: Migration to v10 (OCA#54)
ec2357b
levkar pushed a commit to levkar/contract that referenced this pull request Feb 17, 2018
@thinkwelltwd @lk-eska
[MIG] contract_show_invoice: Migration to v10 (OCA#54)
c0e2d56
sbejaoui pushed a commit to sbejaoui/contract that referenced this pull request Nov 7, 2018
@thinkwelltwd @sbejaoui
[MIG] contract_show_invoice: Migration to v10 (OCA#54)
44d296f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@lasley lasley lasley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thinkwelltwd @oca-clabot @pedrobaeza @JordiBForgeFlow @lasley @dreispt