Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0] contract_invoice_merge_by_partner module #57

Merged
merged 6 commits into from
Mar 31, 2017

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Mar 28, 2017

  • Update README
  • Update views
  • Update tests

cc @Tecnativa

@cubells cubells force-pushed the 9.0-mig-contract_invoice_merge_by_partner branch from c0a55cc to 1706f8c Compare March 28, 2017 21:33
@rafaelbn rafaelbn added this to the 9.0 milestone Mar 28, 2017
@cubells cubells force-pushed the 9.0-mig-contract_invoice_merge_by_partner branch from 1706f8c to d4dc411 Compare March 29, 2017 06:19
@cubells cubells force-pushed the 9.0-mig-contract_invoice_merge_by_partner branch from d4dc411 to 5499e68 Compare March 29, 2017 08:34
Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested on runbot (I've loaded the Sales Management application to access contract menu)

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality tested 👍

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks

@rafaelbn rafaelbn merged commit 82943ec into OCA:9.0 Mar 31, 2017
@pedrobaeza pedrobaeza deleted the 9.0-mig-contract_invoice_merge_by_partner branch March 31, 2017 17:55
@pedrobaeza pedrobaeza mentioned this pull request Mar 31, 2017
9 tasks
@mourad-ehm
Copy link
Contributor

Hi @pedrobaeza, Do you know why this module has not been migrated in the recent versions ?
We have a customer need to merge invoices generated by contracts (by some criteria). I didn't see that this need is covered by the contract modules of v14.

@pedrobaeza
Copy link
Member

We haven't used since this version, but it's still interesting and it's not covered in the base module. The architecture is not the same, so the migration won't be direct I'm afraid.

@mourad-ehm
Copy link
Contributor

mourad-ehm commented Oct 18, 2022

Thank you @pedrobaeza for your response.
We should propose a solution to our customer for merging contracts in the same way of merging invoices.
But we don't delete the the merged contracts but only cancel contract lines (by probably use a renew line method).
In fact, contracts can be merged a long time after their creation, and we want preserve history of invoicing of merged contracts.
If it accepts solution, we w'll propose new module.

@pedrobaeza
Copy link
Member

I don't have clear the possible derivations of such thing, but putting that contract merging in a separate module will avoid debates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants