Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] agreement_legal: Migration to 13.0 #674

Merged
merged 62 commits into from May 14, 2021
Merged

[13.0][MIG] agreement_legal: Migration to 13.0 #674

merged 62 commits into from May 14, 2021

Conversation

victoralmau
Copy link
Member

Migration to 13.0

Please @joao-p-marques and @pedrobaeza can you review it?

@Tecnativa TT27166

@victoralmau victoralmau mentioned this pull request May 11, 2021
Open
20 tasks
@pedrobaeza pedrobaeza added this to the 13.0 milestone May 13, 2021
pedrobaeza
pedrobaeza approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can squash a bunch of initial commits from the same author + administrative ones for having a more compact commit history without losing attribution

@victoralmau victoralmau force-pushed the 13.0-mig-agreement_legal branch 2 times, most recently from 84b96ca to bb11f1d Compare May 14, 2021 06:22
@victoralmau
Copy link
Member Author

Perhaps you can squash a bunch of initial commits from the same author + administrative ones for having a more compact commit history without losing attribution

Thanks @pedrobaeza , changes done.

@pedrobaeza
Copy link
Member

I still see the commits split from the same author and with no significant as autonomous:

Selección_005

ygol and others added 22 commits May 14, 2021 08:32
@ygol @victoralmau
[ADD] agreement_legal migration
f597f4c 
[FIX] flake8(2)
@ygol @victoralmau
[FIX] agreement_legal: remove account dependency
2efe22c 
[FIX] ooops

[UPD] README.rst
@ygol @victoralmau
[FIX] handling code field + partner_id
8619fe6 
[UPD] Update agreement_legal.pot
@ygol @victoralmau
[UPD] remove field reference and use field code
b7aca0c 
Translated using Weblate (French)

Currently translated at 100.0% (301 of 301 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/

[UPD] Update agreement_legal.pot
@ygol @victoralmau
[ADD] custom dynamic parties
88dcc5a 
[FIX] flake8

[FIX] pylint
@ygol @victoralmau
[IMP] add default html value for parties
4124005 
[UPD] flake8
@murtuzasaleh @victoralmau
[FIX][12.0] Menu Icon.
d6acb70 
[UPD] Update agreement_legal.pot
@max3903 @victoralmau
[FIX] Icon in settings
708811f
@max3903 @victoralmau
[FIX] agreement_legal: module name
df4ba87 
[UPD] Update agreement_legal.pot
@rdc02271 @victoralmau
Added translation using Weblate (Portuguese (Portugal))
9ae3221
@max3903 @victoralmau
[FIX] Issue OCA#323 + Cleanup
2479843
@max3903 @victoralmau
Update agreement_section.py
920b013
@max3903 @victoralmau
[FIX] Duplicate label
12891fc
@max3903 @victoralmau
[FIX] Clauses are copied from the sections
6745608
@max3903 @victoralmau
[FIX] agreement_legal: Copy
c6ce2e9
@max3903 @victoralmau
[FIX] View priority
3d68a84
@rdc02271 @victoralmau
Translated using Weblate (Portuguese (Portugal))
50be8e2 
Currently translated at 2.7% (7 of 260 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_PT/

Translated using Weblate (Portuguese (Portugal))

Currently translated at 21.9% (57 of 260 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_PT/
@max3903 @victoralmau
[FIX] Issue OCA#331
50e6109 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/
@max3903 @victoralmau
[IMP] agreement_legal: add readonly group
443c578 
[UPD] Update agreement_legal.pot

[UPD] Update agreement_legal.pot
@ygol @victoralmau
[UPD] update agreement demo data with compulsory fields
0147da4
@ygol @victoralmau
[UPD] move data to demo keyword
3f363b9
@ygol @victoralmau
[UPD] PR review's remarks
263ccd0
MiquelRForgeFlow and others added 13 commits May 14, 2021 08:32
@MiquelRForgeFlow @victoralmau
[FIX] company_partner_id and partner_id have the same label: Partner.
c8c1de4 
[UPD] Update agreement_legal.pot

agreement_legal 12.0.1.2.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/

agreement_legal 12.0.1.3.0
@alvarorib @victoralmau
Translated using Weblate (Portuguese)
34cca6e 
Currently translated at 99.6% (284 of 285 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt/

agreement_legal 12.0.1.3.1

[UPD] Update agreement_legal.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/
@victoralmau
[IMP] agreement,agreement_legal: support activities
4123bea 
- The `agreement` model now features mail and activities from its base module.
- The `agreement_legal` module doesn't need to add mail support now.
- Add activities to form views.

@Tecnativa TT22477

[UPD] Update agreement_legal.pot

agreement_legal 12.0.1.4.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/

[UPD] Update agreement_legal.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/
@victoralmau
Translated using Weblate (Portuguese (Brazil))
4e437c5 
Currently translated at 100.0% (285 of 285 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/
@nelsonramirezs @victoralmau
Added translation using Weblate (Spanish)
a38eb9b 
[UPD] Update agreement_legal.pot

Translated using Weblate (Spanish)

Currently translated at 14.0% (40 of 285 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/es/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/

Translated using Weblate (Spanish)

Currently translated at 99.3% (284 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/es/

[UPD] README.rst

[UPD] README.rst

agreement_legal 12.0.1.4.1
@murtuzasaleh @victoralmau
[FIX] agreement_legal
3e3bca9
@fcolus @victoralmau
Translated using Weblate (Portuguese (Brazil))
bcfcf27 
Currently translated at 100.0% (286 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/
@pedrobaeza @victoralmau
Translated using Weblate (Spanish)
d4ee9b2 
Currently translated at 99.3% (284 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/es/
@fcolus @victoralmau
Translated using Weblate (Portuguese (Brazil))
12d7a1c 
Currently translated at 100.0% (286 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (286 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/

Translated using Weblate (French)

Currently translated at 98.6% (282 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/
@britoederr @victoralmau
Translated using Weblate (Portuguese (Brazil))
5fe56be 
Currently translated at 100.0% (286 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/
@remi-filament @victoralmau
Translated using Weblate (French)
a78e44b 
Currently translated at 100.0% (286 of 286 strings)

Translation: contract-12.0/contract-12.0-agreement_legal
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/
@newtratip @victoralmau
[12.0][FIX] agreement_legal: Error when mass action on list view
387e695 
agreement_legal 12.0.2.0.1
@victoralmau
[IMP] agreement_legal: black, isort, prettier
2ff0685
@victoralmau
Copy link
Member Author

I have joined more commits now.

CarlosRoca13
CarlosRoca13 reviewed May 14, 2021
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but in ES6 it's more usual to use let or const depending on whether they are constants or variables

agreement_legal/static/src/js/domain_widget_ext.js Outdated Show resolved Hide resolved
agreement_legal/static/src/js/domain_widget_ext.js Outdated Show resolved Hide resolved
agreement_legal/static/src/js/domain_widget_ext.js Outdated Show resolved Hide resolved
agreement_legal/static/src/js/domain_widget_ext.js Outdated Show resolved Hide resolved
@victoralmau
Copy link
Member Author

Thanks @CarlosRoca13 , changes done.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-674-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 92ad461 into OCA:13.0 May 14, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f67172b. Thanks a lot for contributing to OCA. ❤️

olgamarcocb pushed a commit to tegin/contract that referenced this pull request Nov 16, 2021
@OCA-git-bot
Merge PR OCA#674 into 13.0
e71fb2a 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet