Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][FIX] contract: Invoice supplier form view from contract link #84

Merged
merged 5 commits into from
Sep 19, 2017

Conversation

carlosdauden
Copy link
Contributor

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change module version

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tests, add a child, assign a contract, and check that the count is correct in both the child and the parent.

'name': 'Partner test',
'customer': True,
})
# cls.partner = cls.env.ref('base.res_partner_2')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't comment, but remove

@@ -85,6 +87,9 @@
<field name="model">account.analytic.account</field>
<field name="inherit_id" ref="analytic.view_account_analytic_account_search"/>
<field name="arch" type="xml">
<field name="partner_id" position="attributes">
<attribute name="operator">child_of</attribute>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to create another different line with this behavior, so that you can search by exact partner, or by the partner and its childs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To search by exact partner you can use advanced search or group by partner.
Alternatives appears a strange code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's not the problem. The problem is that you are modifying the behavior of this search in all the account analytic views. Another alternative is to make a primary view and put it only on contract menu action, not in the rest.

@rafaelbn rafaelbn added this to the 9.0 milestone Aug 24, 2017
@rafaelbn
Copy link
Member

@pedrobaeza I think @carlosdauden attend you comments, so please review. After this I will test it in runbot. thanks!

@rafaelbn rafaelbn self-assigned this Aug 24, 2017
@pedrobaeza
Copy link
Member

I don't think so

@rafaelbn rafaelbn removed their assignment Aug 31, 2017
@rafaelbn rafaelbn self-requested a review August 31, 2017 14:42
@carlosdauden
Copy link
Contributor Author

@pedrobaeza changes done

@pedrobaeza
Copy link
Member

@rafaelbn please review

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in runbot 👍

Please @carlosdauden could you make PR for v10 please?

@rafaelbn rafaelbn merged commit 87e0616 into OCA:9.0 Sep 19, 2017
@rafaelbn rafaelbn deleted the 9.0-IMP-contract branch September 19, 2017 16:59
carlosdauden added a commit to Tecnativa/contract that referenced this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants