-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0][FIX] contract: Invoice supplier form view from contract link #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change module version
9eaa866
to
2e84689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In tests, add a child, assign a contract, and check that the count is correct in both the child and the parent.
contract/tests/test_contract.py
Outdated
'name': 'Partner test', | ||
'customer': True, | ||
}) | ||
# cls.partner = cls.env.ref('base.res_partner_2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't comment, but remove
contract/views/contract.xml
Outdated
@@ -85,6 +87,9 @@ | |||
<field name="model">account.analytic.account</field> | |||
<field name="inherit_id" ref="analytic.view_account_analytic_account_search"/> | |||
<field name="arch" type="xml"> | |||
<field name="partner_id" position="attributes"> | |||
<attribute name="operator">child_of</attribute> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to create another different line with this behavior, so that you can search by exact partner, or by the partner and its childs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To search by exact partner you can use advanced search or group by partner.
Alternatives appears a strange code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that's not the problem. The problem is that you are modifying the behavior of this search in all the account analytic views. Another alternative is to make a primary view and put it only on contract menu action, not in the rest.
@pedrobaeza I think @carlosdauden attend you comments, so please review. After this I will test it in runbot. thanks! |
I don't think so |
6d0a858
to
00fc108
Compare
@pedrobaeza changes done |
@rafaelbn please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in runbot 👍
Please @carlosdauden could you make PR for v10 please?
@Tecnativa