[FIX] contract: Template lines handling #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasley
force-pushed
the
bugfix/10.0/gh-80-template_invoice_lines
branch
from
6328eae
to
d3f3e4f
Compare
lasley
commented
Aug 22, 2017
| @@ -16,23 +16,44 @@ class AccountAnalyticInvoiceLine(models.Model): | |||
| _name = 'account.analytic.invoice.line' | |||
|
|
|||
| product_id = fields.Many2one( | |||
| 'product.product', string='Product', required=True) | |||
| 'product.product', | |||
There was a problem hiding this comment.
Reviewers - sorry I killed the diff here - I was having a hard time auditing the fields for required, etc. so had to clean up the spacing
|
Why the coverage drop? |
|
I missed a spot! |
lasley
force-pushed
the
bugfix/10.0/gh-80-template_invoice_lines
branch
from
ee9e048
to
45b0cc0
Compare
pedrobaeza
reviewed
Aug 23, 2017
|
|
||
| @api.multi | ||
| @api.onchange('product_id') | ||
| def _onchange_product_id(self): |
There was a problem hiding this comment.
Why this extra method is needed?
There was a problem hiding this comment.
The _onchange_product_id in account.analytic.invoice.line uses the partner pretty heavily, which isn't available in the contract.line. This method performs similar operation, just with the user partner instead.
I guess alternatively I could just add some try/excepts in the invoice line. I'll try that
lasley
force-pushed
the
bugfix/10.0/gh-80-template_invoice_lines
branch
from
ea0178c
to
79ecd02
Compare
pedrobaeza
reviewed
Aug 24, 2017
contract/__manifest__.py
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| { | |||
| 'name': 'Contracts Management - Recurring', | |||
| 'version': '10.0.1.1.0', | |||
| 'version': '10.0.1.1.1', | |||
There was a problem hiding this comment.
Module version should raise at least to 10.0.1.2.0, but this can be considered a huge change and it should be 10.0.2.0.0
pedrobaeza
approved these changes
Aug 24, 2017
hurrinico
approved these changes
Sep 25, 2017
feketemihai
pushed a commit
to feketemihai/contract
that referenced
this pull request
Nov 13, 2017
pedrobaeza
pushed a commit
to feketemihai/contract
that referenced
this pull request
Nov 18, 2017
pedrobaeza
pushed a commit
to feketemihai/contract
that referenced
this pull request
Nov 19, 2017
pedrobaeza
pushed a commit
to feketemihai/contract
that referenced
this pull request
Nov 19, 2017
sbejaoui
pushed a commit
to sbejaoui/contract
that referenced
this pull request
Oct 25, 2018
pedrobaeza
pushed a commit
to sbejaoui/contract
that referenced
this pull request
Oct 27, 2018
sbejaoui
pushed a commit
to sbejaoui/contract
that referenced
this pull request
Jan 24, 2019
devCbssolutionsRo
pushed a commit
to devCbssolutionsRo/contract
that referenced
this pull request
Dec 19, 2019
AaronHForgeFlow
pushed a commit
to ForgeFlow/contract
that referenced
this pull request
Apr 24, 2020
pedrobaeza
pushed a commit
to Tecnativa/contract
that referenced
this pull request
Jul 14, 2020
ozono
pushed a commit
to ozono/contract
that referenced
this pull request
Nov 7, 2020
ozono
pushed a commit
to ozono/contract
that referenced
this pull request
Nov 14, 2020
dnplkndll
pushed a commit
to Kencove/contract
that referenced
this pull request
Dec 6, 2020
ozono
pushed a commit
to ozono/contract
that referenced
this pull request
Apr 2, 2021
jcdrubay
pushed a commit
to jcdrubay/contract
that referenced
this pull request
Oct 28, 2021
olgamarcocb
pushed a commit
to tegin/contract
that referenced
this pull request
Nov 16, 2021
wpichler
pushed a commit
to wpichler/contract
that referenced
this pull request
Oct 24, 2022
pedrobaeza
pushed a commit
to wpichler/contract
that referenced
this pull request
Mar 15, 2023
peluko00
pushed a commit
to APSL/contract
that referenced
this pull request
Feb 15, 2024
jaydeep32
pushed a commit
to archeti-org/contract
that referenced
this pull request
Feb 15, 2024
CRogos
pushed a commit
to c4a8-odoo/module-oca-contract
that referenced
this pull request
Mar 23, 2024
CRogos
pushed a commit
to c4a8-odoo/module-oca-contract
that referenced
this pull request
Mar 23, 2024
CRogos
pushed a commit
to c4a8-odoo/module-oca-contract
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @fgarcia-humanoide