-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] contract: Template lines handling #92
[FIX] contract: Template lines handling #92
Conversation
6328eae
to
d3f3e4f
Compare
@@ -16,23 +16,44 @@ class AccountAnalyticInvoiceLine(models.Model): | |||
_name = 'account.analytic.invoice.line' | |||
|
|||
product_id = fields.Many2one( | |||
'product.product', string='Product', required=True) | |||
'product.product', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewers - sorry I killed the diff here - I was having a hard time auditing the fields for required, etc. so had to clean up the spacing
Why the coverage drop? |
I missed a spot! |
ee9e048
to
45b0cc0
Compare
|
||
@api.multi | ||
@api.onchange('product_id') | ||
def _onchange_product_id(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this extra method is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _onchange_product_id
in account.analytic.invoice.line
uses the partner pretty heavily, which isn't available in the contract.line
. This method performs similar operation, just with the user partner instead.
I guess alternatively I could just add some try/excepts in the invoice line. I'll try that
ea0178c
to
79ecd02
Compare
contract/__manifest__.py
Outdated
@@ -5,7 +5,7 @@ | |||
|
|||
{ | |||
'name': 'Contracts Management - Recurring', | |||
'version': '10.0.1.1.0', | |||
'version': '10.0.1.1.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module version should raise at least to 10.0.1.2.0
, but this can be considered a huge change and it should be 10.0.2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 👍
Tested Locally works well!
cc @fgarcia-humanoide