Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][REF] cooperator: Save sequences on company #74

Merged
merged 6 commits into from
Jul 25, 2023
Merged

[14.0][REF] cooperator: Save sequences on company #74

merged 6 commits into from
Jul 25, 2023

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Jun 9, 2023 •
edited

@carmenbianca carmenbianca force-pushed the 14.0-cooperator-sequence-multi-company branch 2 times, most recently from 9f24ae5 to fe6321b Compare June 9, 2023 14:17
@carmenbianca carmenbianca marked this pull request as ready for review June 9, 2023 14:24
huguesdk
huguesdk requested changes Jun 12, 2023
View reviewed changes
cooperator/models/account_move.py Outdated Show resolved Hide resolved
cooperator/migrations/14.0.1.7.0/pre-migration.py Outdated Show resolved Hide resolved
cooperator/models/account_move.py Outdated Show resolved Hide resolved
@carmenbianca
[REF] cooperator: Save sequences on company
224e21d 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[IMP] cooperator: Migration script for sequences
faea516 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[FIX] cooperator: Set company on sequences in migration script
87e1575 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca carmenbianca force-pushed the 14.0-cooperator-sequence-multi-company branch from a6b3271 to 87e1575 Compare June 13, 2023 08:24
huguesdk
huguesdk requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still references to the xml ids of the sequences here and here.

@carmenbianca
[REF] cooperator: Get sequence by code instead of saving it on company
ec96c5a 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[IMP] cooperator: Use data function instead of post-init hook to crea…
fc67b60 
…te sequences on company

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca carmenbianca force-pushed the 14.0-cooperator-sequence-multi-company branch from 4fc4cfd to fc67b60 Compare June 14, 2023 14:49
DaniilDigtyar
DaniilDigtyar approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@DaniilDigtyar DaniilDigtyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

enricostano
enricostano approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👏

XavierBonetViura
XavierBonetViura approved these changes Jun 22, 2023
View reviewed changes
Copy link

@XavierBonetViura XavierBonetViura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@huguesdk huguesdk mentioned this pull request Jul 14, 2023
Merged
@OCA-git-bot OCA-git-bot merged commit a38973b into OCA:14.0 Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguesdk huguesdk huguesdk requested changes

@enricostano enricostano enricostano approved these changes

@DaniilDigtyar DaniilDigtyar DaniilDigtyar approved these changes

@XavierBonetViura XavierBonetViura XavierBonetViura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carmenbianca @enricostano @huguesdk @DaniilDigtyar @XavierBonetViura @OCA-git-bot