-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] account_financial_risk: Migration to 14.0 #105
[MIG] account_financial_risk: Migration to 14.0 #105
Conversation
* [9.0][IMP] partner_financial_risk: Improve performance * [9.0][IMP] partner_financial_risk: Improve tests and partner hierarchy * [9.0][IMP] partner_stock_risk: Test
- Refunds adds partner risk instead of reduce. - If date_maturity changes to previous today date "never" compute partner risk.
* [9.0][IMP] partner_financial_risk: Improve multicompany cron * [9.0][IMP] partner_financial_risk: Exec with sudo (cherry picked from commit 6590bbf)
Currently translated at 71.2% (52 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/fr/
Currently translated at 79.5% (58 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/it/
Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es/
Currently translated at 13.7% (10 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es_CL/
Currently translated at 76.7% (56 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt_BR/
Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt/
…ption. Improve views and translations.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/
I'm seeing anyway that you haven't done the procedure depicted in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0 properly, as you have to pass pre-commit just after the commit history preservation. You should squash as well all your migration commits into one. Please do it. |
175cbe9
to
5de11b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionally and only one change requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attend @alan196 request changes
Can you please squash migration commits? |
bc06233
to
5d95c65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C̶o̶u̶l̶d̶ ̶y̶o̶u̶ ̶p̶l̶e̶a̶s̶e̶ ̶c̶o̶n̶s̶i̶d̶e̶r̶ ̶t̶h̶i̶s̶ ̶P̶R̶ ̶h̶t̶t̶p̶s̶:̶/̶/̶g̶i̶t̶h̶u̶b̶.̶c̶o̶m̶/̶O̶C̶A̶/̶c̶r̶e̶d̶i̶t̶-̶c̶o̶n̶t̶r̶o̶l̶/̶p̶u̶l̶l̶/̶1̶1̶1̶ ̶i̶t̶ ̶j̶u̶s̶t̶ ̶g̶e̶t̶ ̶m̶e̶r̶g̶e̶d̶ ̶y̶e̶s̶t̶e̶r̶d̶a̶y̶ ̶a̶n̶d̶ ̶i̶t̶ ̶a̶f̶f̶e̶c̶t̶s̶ ̶a̶l̶s̶o̶ ̶V̶1̶4̶
But that PR is for another module, isn't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that! I get confused 👍
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 437304d. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa