Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] account_financial_risk: Migration to 14.0 #105

Merged
merged 46 commits into from
Nov 26, 2020

Conversation

psugne
Copy link
Contributor

@psugne psugne commented Oct 29, 2020

carlosdauden and others added 30 commits October 28, 2020 09:39
* [9.0][IMP] partner_financial_risk: Improve performance

* [9.0][IMP] partner_financial_risk: Improve tests and partner hierarchy

* [9.0][IMP] partner_stock_risk: Test
- Refunds adds partner risk instead of reduce.
- If date_maturity changes to previous today date "never" compute partner risk.
* [9.0][IMP] partner_financial_risk: Improve multicompany cron

* [9.0][IMP] partner_financial_risk: Exec with sudo

(cherry picked from commit 6590bbf)
Currently translated at 71.2% (52 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/fr/
Currently translated at 79.5% (58 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/it/
Currently translated at 100.0% (73 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es/
Currently translated at 13.7% (10 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es_CL/
Currently translated at 76.7% (56 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt_BR/
Currently translated at 100.0% (73 of 73 strings)

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-12.0/credit-control-12.0-account_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/
@pedrobaeza
Copy link
Member

I'm seeing anyway that you haven't done the procedure depicted in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0 properly, as you have to pass pre-commit just after the commit history preservation. You should squash as well all your migration commits into one. Please do it.

@psugne psugne force-pushed the 14.0-mig-account_financial_risk branch from 175cbe9 to 5de11b0 Compare November 10, 2020 08:58
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionally and only one change requested

Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attend @alan196 request changes

@pedrobaeza
Copy link
Member

Can you please squash migration commits?

@psugne psugne force-pushed the 14.0-mig-account_financial_risk branch from bc06233 to 5d95c65 Compare November 20, 2020 10:42
@psugne psugne requested a review from alan196 November 20, 2020 10:42
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C̶o̶u̶l̶d̶ ̶y̶o̶u̶ ̶p̶l̶e̶a̶s̶e̶ ̶c̶o̶n̶s̶i̶d̶e̶r̶ ̶t̶h̶i̶s̶ ̶P̶R̶ ̶h̶t̶t̶p̶s̶:̶/̶/̶g̶i̶t̶h̶u̶b̶.̶c̶o̶m̶/̶O̶C̶A̶/̶c̶r̶e̶d̶i̶t̶-̶c̶o̶n̶t̶r̶o̶l̶/̶p̶u̶l̶l̶/̶1̶1̶1̶ ̶i̶t̶ ̶j̶u̶s̶t̶ ̶g̶e̶t̶ ̶m̶e̶r̶g̶e̶d̶ ̶y̶e̶s̶t̶e̶r̶d̶a̶y̶ ̶a̶n̶d̶ ̶i̶t̶ ̶a̶f̶f̶e̶c̶t̶s̶ ̶a̶l̶s̶o̶ ̶V̶1̶4̶

@pedrobaeza
Copy link
Member

But that PR is for another module, isn't it?

Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! I get confused 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-105-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 20, 2020
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-105-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 20, 2020
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-105-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza mentioned this pull request Nov 26, 2020
6 tasks
@OCA-git-bot OCA-git-bot merged commit cd832ce into OCA:14.0 Nov 26, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 437304d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet