12.0 mig sale_financial_risk #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestotejeda
force-pushed
the
12.0-mig-sale_financial_risk
branch
from
70075a3
to
3769244
Compare
pedrobaeza
reviewed
Mar 7, 2019
yajo
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
The new field seems expensive, but at least it's stored, so it shouldn't be much of a problem.
The read_group isn't a panacea: it saves some Python loops, but at the cost of increasing SQL queries (because you can't benefit of caching and prefetching). I think we can defer that "fix" until we see it's actually a problem.
Code OK, just some little obvious remarks for a little better performance.
ernestotejeda
force-pushed
the
12.0-mig-sale_financial_risk
branch
from
3769244
to
f39b951
Compare
|
@carlosdauden your last call about the method's performance. @ernestotejeda please cover with tests all the code for not dropping coverage. |
Done |
…invoices) Company currency
[IMP] sale_financial_risk: Simplify code (Remove no directly related invoices)
ernestotejeda
force-pushed
the
12.0-mig-sale_financial_risk
branch
from
cbe22da
to
12824cb
Compare
carlosdauden
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @Tecnativa