[12.0][MIG] account_credit_control #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
MiquelRForgeFlow
force-pushed
the
12.0-mig-account_credit_control
branch
3 times, most recently
from
8e96858
to
5d338fd
Compare
|
@mreficent does #18 's comments applied here? |
24 tasks
cubells
suggested changes
Apr 5, 2019
* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations
* Fix failure to confirm invoice when both account_credit_control and account_constraints are installed * use except_orm instead of except_osv * reindent code * Cleanup * use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report
* Report use precise mode by default * date_entry fields on line model to be used by report or in next MP on filter group by * reporting layer, + add hook function to get contact address * credit control mail are not in plain text but send as attachement * policy level name is now translatable as it is use in report and mail * permission on invoices because onetomany widget load data even if hidden ... * translation files + lang source * french translation
* Translation + report invoice address layout * Label Force credit control policy + french translation
…when partners or accounts are duplicated
…e in non draft state before deleting it
* pep8 (space after comma, reduced length of lines) * does not need to check if there is ids before calling unlink, it will return early * remove unused import * 'raise a new invoice' is a British English expression for 'issue a new invoice'
…ranslation extraction
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP. * bug 1287072 Level calculation error if previous credit line is ignored * unifing wizard views to respect UI guide lines * credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice * test to ensure that wizard run on customer invoice * Scenario that test coherence of credit run after manually altering an invoice level * multicurrency in communication * ...
…ding _unported suffix
* Partner Form view: field "credit_limit" is defined in account module, not base * Minimal Danish translation * Do not link e-mails to Transient records Transient records are deleted periodically so res_id will point to ID which does not exists. And when reading email records system would also check if res_id can be read by user which would cause an exception because res_id might not exist at that point.
…ntributions: OCA/account-financial-tools@f9bc46a#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@6c684f5#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@3c7475c#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@09260a0#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@3029a63#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@ad44b40#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@c45538e#diff-d2d83592881bd999fbe1e6f32a0a244a OCA/account-financial-tools@b125a79#diff-d2d83592881bd999fbe1e6f32a0a244a
Currently translated at 71.3% (149 of 209 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/de/
Currently translated at 86,1% (180 of 209 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/nl/
Currently translated at 100,0% (209 of 209 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/de/
Currently translated at 100.0% (209 of 209 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/nl/
Currently translated at 95.7% (200 of 209 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/es/
…ti-company issues
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/ [UPD] Update account_credit_control.pot
Currently translated at 12.0% (26 of 217 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/nl_NL/
…trol.policy for group_account_user
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_credit_control/
MiquelRForgeFlow
force-pushed
the
12.0-mig-account_credit_control
branch
from
5d338fd
to
c521746
Compare
|
@pedrobaeza I think it's ready! |
|
Well, everything is red... |
MiquelRForgeFlow
force-pushed
the
12.0-mig-account_credit_control
branch
from
c521746
to
88404c7
Compare
|
Yeah, now is green 😁 |
pedrobaeza
reviewed
Apr 5, 2019
MiquelRForgeFlow
force-pushed
the
12.0-mig-account_credit_control
branch
from
88404c7
to
b537dac
Compare
pedrobaeza
approved these changes
Apr 8, 2019
astirpe
reviewed
Apr 30, 2019
Co-Authored-By: mreficent <miquel.raich@eficent.com>
|
Merging as comment resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from OCA/account-financial-tools#779.