[15.0][MIG] account_credit_control: Migration to 15.0 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check CI |
|
CI is still red, @cesar-tecnativa |
cesar-tecnativa
force-pushed
the
15.0-mig-account_credit_control
branch
2 times, most recently
from
cc9dfe2
to
eb0f0cc
Compare
|
TT36416 |
|
@pedrobaeza Could you please review? |
|
@victoralmau could you please review? |
|
@LudLaf could you review this? |
BT-anieto
suggested changes
Jul 5, 2022
|
@cesar-tecnativa credit_control_policy field is not existing. How it is right now it breaks the update. |
BT-anieto
reviewed
Jul 5, 2022
|
On the other hand, I guess the migrations folder should be deleted. |
BT-anieto
reviewed
Jul 5, 2022
* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations
* Fix failure to confirm invoice when both account_credit_control and account_constraints are installed * use except_orm instead of except_osv * reindent code * Cleanup * use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report
* Report use precise mode by default * date_entry fields on line model to be used by report or in next MP on filter group by * reporting layer, + add hook function to get contact address * credit control mail are not in plain text but send as attachement * policy level name is now translatable as it is use in report and mail * permission on invoices because onetomany widget load data even if hidden ... * translation files + lang source * french translation
* Translation + report invoice address layout * Label Force credit control policy + french translation
…when partners or accounts are duplicated
…e in non draft state before deleting it
* pep8 (space after comma, reduced length of lines) * does not need to check if there is ids before calling unlink, it will return early * remove unused import * 'raise a new invoice' is a British English expression for 'issue a new invoice'
…ranslation extraction
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP. * bug 1287072 Level calculation error if previous credit line is ignored * unifing wizard views to respect UI guide lines * credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice * test to ensure that wizard run on customer invoice * Scenario that test coherence of credit run after manually altering an invoice level * multicurrency in communication * ...
…ding _unported suffix
Some data was being declared repeating demo data from Odoo Account addon. See https://github.com/odoo/odoo/blob/13.0/addons/account/test/account_minimal_test.xml#L125 and https://github.com/odoo/odoo/blob/13.0/addons/account/test/account_minimal_test.xml#L214 This removes the repeated declaration and adds code in tests to load needed data from the `account` addon. Before this, tests would fail if some other addon tried to create the same demo data. TT26079
cesar-tecnativa
force-pushed
the
15.0-mig-account_credit_control
branch
from
eb0f0cc
to
867c84e
Compare
cesar-tecnativa
force-pushed
the
15.0-mig-account_credit_control
branch
from
867c84e
to
5107db0
Compare
|
@CarlosRoca13 please review |
CarlosRoca13
approved these changes
Jul 7, 2022
espo-tony
approved these changes
Jul 7, 2022
Migrations folder now deleted. |
|
@pedrobaeza Could you please review? |
|
This PR has the |
|
/ocabot merge nobump |
|
/ocabot migration account_credit_control |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 918009a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT36416