[MIG] account_credit_control_dunning_fees: Migration to 12.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout needing overriding
This reverts commit 7eb182744f3057dd5cb9e35faf230412aa7a2331.
…ding _unported suffix
…noqa on scenario while waiting improvement of quality-tools
It will be easier to write additional tests
... on the policy level if it is empty. Also, it fixes a bug when a credit line had no currency and the level had the company's currency. As False is different than any currency, it entered in res_currency.compute() with a False currency. It must just fallback on the company's currency if the credit line's currency is empty.
With that, the suite is run even when we update another module and that not what we expect.
Display the fees column before the open amount, it is more logical since it is invoice amount + fees amount.
To avoid constraint.
Currently translated at 100.0% (20 of 20 strings) Translation: account-financial-tools-10.0/account-financial-tools-10.0-account_credit_control_dunning_fees Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-10-0/account-financial-tools-10-0-account_credit_control_dunning_fees/pt_PT/
Currently translated at 95.0% (19 of 20 strings) Translation: account-financial-tools-10.0/account-financial-tools-10.0-account_credit_control_dunning_fees Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-10-0/account-financial-tools-10-0-account_credit_control_dunning_fees/pt/
…ount-financial-tools into mig-dunning-fee
This was referenced Jun 19, 2019
Closed
i-vyshnevska
approved these changes
Jun 20, 2019
account_credit_control_dunning_fees/tests/test_fees_generation.py
Outdated
Show resolved
Hide resolved
| self.euro = self.currency_model.search([('name', '=', 'EUR')]) | ||
| self.assertTrue(self.euro) | ||
| self.usd = self.currency_model.search([('name', '=', 'USD')]) | ||
| self.assertTrue(self.usd) |
| """Initialize credit control level mock to test fees computations""" | ||
| super(FixedFeesTester, self).setUp() | ||
| self.currency_model = self.env['res.currency'] | ||
| self.euro = self.currency_model.search([('name', '=', 'EUR')]) |
There was a problem hiding this comment.
why do not use self.env.ref('base.EUR')
|
Any news on this ? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.