Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] partner risk insurance #31

Merged
merged 8 commits into from
Dec 31, 2019
Merged

[12.0][MIG] partner risk insurance #31

merged 8 commits into from
Dec 31, 2019

Conversation

omar7r
Copy link
Contributor

@omar7r omar7r commented Oct 11, 2019

Direct migration

@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 11, 2019
@pedrobaeza
Copy link
Member

I think you can squash all these commits together being from same author or administrative ones:

Selección_010

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 11, 2019
Closed
7 tasks
@pedrobaeza
Copy link
Member

You have a runbot warning, but logs are not accessible. I have triggered a rebuild to see if possible to check them. Running in local should appear as well.

sergio-teruel and others added 2 commits October 11, 2019 16:37
@sergio-teruel @omar7r
[11.0][MIG] partner_risk_insurance: Migration to v11.0
23a2f79 
[11.0][MIG] partner_risk_insurance: Migration to v11.0

[11.0][IMP] partner_risk_insurance: Fix ES translation

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-11.0/credit-control-11.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-11-0/credit-control-11-0-partner_risk_insurance/

[UPD] README.rst

[UPD] Update partner_risk_insurance.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-11.0/credit-control-11.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-11-0/credit-control-11-0-partner_risk_insurance/
@omar7r
[MIG] partner_risk_insurance: Migration to v12.0
80fcb5a
@omar7r omar7r force-pushed the 12.0-mig-partner_risk_insurance branch from 1bd070f to 80fcb5a Compare October 11, 2019 14:41
@omar7r
Copy link
Contributor Author

omar7r commented Oct 11, 2019

Squashed.
The unique warning that I saw in my log was: "The model credit.policy.state has no _description", now the object has a description but I don't know if it is the fail.

pedrobaeza
pedrobaeza approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot warning has gone. README needs to be regenerated, but the bot can do it

sergio-teruel
sergio-teruel approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comments.

partner_risk_insurance/README.rst
:target: https://translation.odoo-community.org/projects/credit-control-11-0/credit-control-11-0-partner_risk_insurance
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
:target: https://runbot.odoo-community.org/runbot/262/11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please regenerate the file

partner_risk_insurance/tests/test_partner_risk_insurance.py

class TestSaleOrderLineInput(SavepointCase):
at_install = False
post_install = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @tagged decorator instead

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-31-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 31, 2019
@OCA-git-bot
Merge PR #31 into 12.0
16815b2 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 7539a40 into OCA:12.0 Dec 31, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 338469e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@omar7r @pedrobaeza @OCA-git-bot @sergio-teruel @sysadminmatmoz @Roodin