[17.0][MIG] sale_financial_risk #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiosca-s73
changed the title
sbiosca-s73
force-pushed
the
17.0-mig_sale_financial_risk
branch
from
3c094a8
to
82f088f
Compare
|
/ocabot migration sale_financial_risk |
carlosdauden
suggested changes
May 2, 2024
sbiosca-s73
force-pushed
the
17.0-mig_sale_financial_risk
branch
from
82f088f
to
cb77e01
Compare
|
@carlosdauden changes done |
carlosdauden
suggested changes
May 2, 2024
sbiosca-s73
force-pushed
the
17.0-mig_sale_financial_risk
branch
from
bb179a5
to
2ad78b5
Compare
|
@carlosdauden changes done |
|
Not working test-requirements because the version of module account_financial_risk isn't correctly version |
sbiosca-s73
force-pushed
the
17.0-mig_sale_financial_risk
branch
2 times, most recently
from
e339aeb
to
3db1dfb
Compare
…invoices) Company currency
Currently translated at 7.7% (1 of 13 strings) Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/fr/
Currently translated at 7.7% (1 of 13 strings) Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt_BR/
Currently translated at 46.2% (6 of 13 strings) Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/it/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (21 of 21 strings) Translation: credit-control-16.0/credit-control-16.0-sale_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-sale_financial_risk/es/
This issue appeared for multi-company, multi-currency configuration. Whenever risk was calculated for the partner, Sale Order amount was converted to company currency, instead of currency set on the partner. This commit fixes the issue by converting to correct currency (set on the partner).
The test_manual_currency_risk_not_exceeded test that assesses that the manual currency risk has not been passed fails when another module changes the company's currency. The reason for the failure is that if the company currency matches the currency of the sell order it does not convert correctly and in that case it interprets the limit within the same currency. For example, if the company currency is set as EUR and the sales order is placed in EUR, the conversion of the 100€ is not done and therefore exceeds the limit set to 99. To solve this, the company currency is first checked to set a different currency in the order. On the other hand, the tests should be frozen at a certain date to prevent the exchange rate of the exchange currency from going up or down thus avoiding errors when running the test, which should check that it has not been exceeded.
Currently translated at 100.0% (21 of 21 strings) Translation: credit-control-16.0/credit-control-16.0-sale_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-sale_financial_risk/nl/
sbiosca-s73
force-pushed
the
17.0-mig_sale_financial_risk
branch
6 times, most recently
from
1bd780a
to
3e15923
Compare
ioans73
approved these changes
May 27, 2024
|
This PR has the |
|
@pedrobaeza good work! |
|
You have to give thanks to the contributors doing the migration and the review. @sbiosca-s73 please split the pre-commit changes from the migration itself as stated in the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 |
sbiosca-s73
force-pushed
the
17.0-mig_sale_financial_risk
branch
from
3e15923
to
0c79ab7
Compare
|
@pedrobaeza changes done. Thanks! |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 319bbee. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate sale_financial_risk module to version 17.0