Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] sale_financial_risk #68

Merged
merged 26 commits into from
Jun 19, 2020
Merged

[13.0][MIG] sale_financial_risk #68

merged 26 commits into from
Jun 19, 2020

Conversation

MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Jun 15, 2020 •
edited
Loading

Standard migration.

carlosdauden
carlosdauden suggested changes Jun 15, 2020
View reviewed changes
sale_financial_risk/models/res_partner.py Outdated Show resolved Hide resolved
sale_financial_risk/tests/test_partner_sale_risk.py Outdated Show resolved Hide resolved
carlosdauden and others added 26 commits June 18, 2020 14:49
@carlosdauden @MiquelRForgeFlow
[9.0][ADD] partner_sale_risk: New module
1397354
@oca-transbot @MiquelRForgeFlow
OCA Transbot updated translations from Transifex
25fbaaf
@Ehtaga @MiquelRForgeFlow
[MIG] Partner Sale Risk : Migration to 10.0
91a07ab
@carlosdauden @MiquelRForgeFlow
[MIG] partner_sale_risk: Migration to 11.0
1e71bee
@carlosdauden @MiquelRForgeFlow
[REN] partner_sale_risk > sale_financial_risk
95ed0bb
@carlosdauden @MiquelRForgeFlow
[IMP] sale_financial_risk: Use new core fields amt_to_invoice and amt…
048b98d 
…_invoiced
@carlosdauden @MiquelRForgeFlow
[IMP] sale_financial_risk: Improve layout view. Readme new template
c84a488
@carlosdauden @MiquelRForgeFlow
[IMP] sale_financial_risk: Rename module in translations files
217f39d
@ernestotejeda @MiquelRForgeFlow
[MIG] sale_financial_risk: Migration to 12.0
422b22f
@ernestotejeda @MiquelRForgeFlow
[MIG] sale_financial_risk: Add unit tests
b9ad782
@carlosdauden @MiquelRForgeFlow
[IMP] sale_financial_risk: Simplify code (Remove no directly related …
54565d8 
…invoices)

Company currency
@OCA-git-bot @MiquelRForgeFlow
[ADD] icon.png
7fd5e32
@oca-travis @MiquelRForgeFlow
[UPD] Update sale_financial_risk.pot
f55554a
@chafique-delli @MiquelRForgeFlow
Translated using Weblate (French)
be2a387 
Currently translated at 7.7% (1 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/fr/
@OCA-git-bot @MiquelRForgeFlow
[UPD] README.rst
6f7ce4d
@MiquelRForgeFlow
Translated using Weblate (Portuguese (Brazil))
7323124 
Currently translated at 7.7% (1 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt_BR/
@MarcoCalcagni @MiquelRForgeFlow
Translated using Weblate (Italian)
c8ecbfe 
Currently translated at 46.2% (6 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/it/
@sergio-teruel @MiquelRForgeFlow
[IMP] sale_financial_risk: Fix test crash with other modules due to p…
e1cb731 
…ricelist
@marcelsavegnago @MiquelRForgeFlow
Translated using Weblate (Portuguese (Brazil))
5f48496 
Currently translated at 100.0% (13 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt_BR/
@pedrocasi @MiquelRForgeFlow
Translated using Weblate (Portuguese)
a41a964 
Currently translated at 23.1% (3 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt/
@carlosdauden @MiquelRForgeFlow
[IMP] sale_financial_risk: Bypass risk when payment transaction is au…
3a31db5 
…thorized
@oca-transbot @MiquelRForgeFlow
Update translation files
9763169 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/
@carlosdauden @MiquelRForgeFlow
[IMP] account_financial_risk account_payment_return_financial_risk sa…
8db007a 
…le_financial_risk:

 - Optimize code and change stored computed fields to not store to improve multi-company support
 - Improve multi-currency support
 - Convert risk amount fields to clickable link that shows traceability of amount origin
 - New pivot views to risk amount traceability
 - Simplify class style applied on risk fields
 - Migration script to remove old stored computed fields
 - Improve tests to cover new functionallity
 - Update translation files

account_financial_risk:
 - Don't block refund invoice validation when partner has risk exception
 - Allow search partners by risk exception field
 - Remove obsolete cron

sale_financial_risk
 - Create related store commercial_partner_id field in sale order line to simplify computation
 - Rename amt_to_invoice field to risk_amount in sale order line
 - Hook and migration scripts to reduce new fields computing time

TT23765
@oca-transbot @MiquelRForgeFlow
Update translation files
331cf93 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/
@MiquelRForgeFlow
[IMP] sale_financial_risk: black, isort, prettier
ad6c213
@MiquelRForgeFlow
[MIG] sale_financial_risk: Migration to 13.0
1d120b6
@carlosdauden
Copy link
Contributor

Can you rebase?
#67 is merged.

@MiquelRForgeFlow
Copy link
Contributor Author

I already did. If not, travis wouldn't be green. :)

@carlosdauden
Copy link
Contributor

Ups, sorry.
I have this tab open and it seems that my browser had not refreshed well because I was still seeing it red.

@carlosdauden
Copy link
Contributor

In fact I had been surprised that the check of the first comment did not appear marked...

@pedrobaeza
Copy link
Member

Should we use then this one instead of respecting @sergio-teruel's first PR?

@sergio-teruel
Copy link
Contributor

For me Ok... no problem...,

@pedrobaeza pedrobaeza mentioned this pull request Jun 19, 2020
Closed
@pedrobaeza pedrobaeza added this to the 13.0 milestone Jun 19, 2020
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-68-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 19, 2020
Closed
6 tasks
@OCA-git-bot OCA-git-bot merged commit 4bb7f45 into OCA:13.0 Jun 19, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a6b7608. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-mig-sale_financial_risk branch June 19, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet