[12.0] Add module account_invoice_overdue_reminder #69

alexis-via · 2020-06-15T16:38:53Z

No description provided.

alexis-via · 2020-06-15T19:07:53Z

I'm working on backporting this module to v10. Where should I propose it ? There isn't any 10.0 branch on this project (starts at 11.0)...

alexis-via · 2020-06-22T15:40:46Z

FYI, PR for v10 is here: #77

ps-tubtim · 2020-07-22T08:44:32Z

account_invoice_overdue_reminder/models/account_invoice_overdue_reminder.py

+    def name_get(self):
+        res = []
+        for rec in self:
+            name = _('%s Reminder %d') % (rec.invoice_id.number, rec.counter)


Suggested change

name = _('%s Reminder %d') % (rec.invoice_id.number, rec.counter)

name = _("{} Reminder {}".format(rec.invoice_id.number, rec.counter))

I think a new format is better. What do you think about it?

What is the real advantage of it ? The result is the same, no ?

In this place, the result is the same but the new format string syntax has become more powerful without complicating the simpler use cases. You can see other reasons in https://realpython.com/python-string-formatting/#which-string-formatting-method-should-you-use.

Thanks to inform us about string formatting. As it's python 3.6+ I wonder if it works like that
name = _(f'{rec.invoice_id.number} Reminder {rec.counter}')

If yes the syntax is really readable

ps-tubtim · 2020-07-22T08:52:43Z

account_invoice_overdue_reminder/models/overdue_reminder_action.py

+            name = _('%s, Reminder %s') % (
+                action.commercial_partner_id.display_name, action.date)


Suggested change

name = _('%s, Reminder %s') % (

action.commercial_partner_id.display_name, action.date)

name = _("{}, Reminder {}".format(action.commercial_partner_id.display_name, action.date))

Same comments as above.

Saran440

Functional Test, LGTM 👍

and code reviewed:

@alexis-via
File name (,py and .xml) that depend core should be used name same as a core odoo
i.e.
company.py should be res_company.py
config_settings.py should be res_config_settings.py
partner.py should be res_partner.py

Saran440 · 2020-08-10T06:14:22Z

account_invoice_overdue_reminder/__manifest__.py

+
+{
+    'name': 'Overdue Invoice Reminder',
+    'version': '12.0.2.0.0',


Suggested change

'version': '12.0.2.0.0',

'version': '12.0.1.0.0',

Module should be start at version 12.0.1.0.0

Héhé, this module already had a "long" life, is already used in production ! And there are migration scripts associated with this version number (due to changes in the datamodel), so I won't change it!

Saran440 · 2020-08-10T06:21:42Z

account_invoice_overdue_reminder/data/overdue_reminder_result.xml

+<odoo noupdate="1">
+
+
+<record id="voicemail" model="overdue.reminder.result">


Suggested change

<record id="voicemail" model="overdue.reminder.result">

<record id="voicemail" model="overdue.reminder.result">

Could you tab before code, it'll look good.

When you have large spaced files begin at the first char make it more readable avoiding too many break lines

In v13, I'll apply black formatting. In the meantime, let's focus on the important things please.

bealdav · 2020-08-21T13:04:45Z

@Saran440 Thanks for your review. IMHO, renaming company.py (or other) to res_company.py is useless.
It's non ambiguous. Thanks for your approbation

…instead of supplier invoice form

…CA#69 : - It added in our fork because in this time was not merged in OCA.

…update your mail templates) Add ability to add contacts as Cc of the reminder email (added to the Cc of the mail template) Add partner_policy with 3 options to give some choice about which contact should be selected to send reminders Access reminders from partner via Action menu

Advantages: 1) easy access to the history in the chatter of the partner. 2) no problem to access the email by other users (avoid "The requested operation cannot be completed due to security restrictions. Please contact your system administrator.")

account_invoice_overdue_reminder/models/company.py

account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py

Co-authored-by: ypapouin <y.papouin@dec-industrie.com>

alexis-via · 2020-11-24T14:46:08Z

@ypapouin Thanks for your review; nice catch for the selection field.
Could you approve the PR now ?

marcelsavegnago

LGTM

ypapouin

Tested in production

ypapouin · 2020-12-11T09:43:06Z

We just got an issue in production, I'm not sure if its an odoo bug or a misusing of transient model and attachments.
The full traceback is added below.

This is my analysis:

Overdue reminder wizard start by the accountant.
A first overdue.reminder.step instance has been created and an attachment (PDF invoice ?) is linked to this model.
The accountant has stopped the wizard to do something else.
Few minutes later, the accountant restart the overdue reminder wizard, but an exception is raised (see traceback) after clicking on start

This is my technical analysis:

At step 4, existing_actions.unlink() is called to delete all our overdue.reminder.step instances
When unlinking the existing overdue.reminder.step, one attachment is found so attachments.unlink() is called to remove it
In ir.attachment.check(...) there is call to self.env[res_model].browse(res_ids).exists() that returns an empty record and 🔥.

            records = self.env[res_model].browse(res_ids).exists()
            # For related models, check if we can write to the model, as unlinking
            # and creating attachments can be seen as an update to the model
            access_mode = 'write' if mode in ('create', 'unlink') else mode
            records.check_access_rights(access_mode)
            records.check_access_rule(access_mode)

Note that the deletion works perfectly when called from the auto-vacuum cron since _filter_access_rules is ignored for SUPERUSER_ID.

So my conclusion:

An attachment should not be linked to a transient model.
Or this is a bug in odoo and _filter_access_rules should not execute its SELECT query when the record is empty.

The traceback:

Traceback (most recent call last):
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 685, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 343, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File "/media/data/dec/projects/12.0/odoo/odoo/tools/pycompat.py", line 87, in reraise
    raise value
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 727, in dispatch
    result = self._call_function(**self.params)
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 375, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/media/data/dec/projects/12.0/odoo/odoo/service/model.py", line 98, in wrapper
    return f(dbname, *args, **kwargs)
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 368, in checked_call
    result = self.endpoint(*a, **kw)
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 979, in __call__
    return self.method(*args, **kw)
  File "/media/data/dec/projects/12.0/odoo/odoo/http.py", line 548, in response_wrap
    response = f(*args, **kw)
  File "/media/data/dec/projects/12.0/odoo/addons/web/controllers/main.py", line 966, in call_button
    action = self._call_kw(model, method, args, {})
  File "/media/data/dec/projects/12.0/odoo/addons/web/controllers/main.py", line 954, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/media/data/dec/projects/12.0/odoo/odoo/api.py", line 761, in call_kw
    return _call_kw_multi(method, model, args, kwargs)
  File "/media/data/dec/projects/12.0/odoo/odoo/api.py", line 748, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/media/data/dec/projects/12.0/odoo-addons/oca/credit-control/account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py", line 125, in run
    existing_actions.unlink()
  File "/media/data/dec/projects/12.0/odoo/odoo/models.py", line 3199, in unlink
    attachments.unlink()
  File "/media/data/dec/projects/12.0/odoo/odoo/addons/base/models/ir_attachment.py", line 501, in unlink
    self.check('unlink')
  File "/media/data/dec/projects/12.0/odoo/odoo/addons/base/models/ir_attachment.py", line 384, in check
    records.check_access_rule(mode)
  File "/media/data/dec/projects/12.0/odoo/odoo/models.py", line 3073, in check_access_rule
    invalid = self - self._filter_access_rules(operation)
  File "/media/data/dec/projects/12.0/odoo/odoo/models.py", line 3118, in _filter_access_rules
    self._cr.execute(query, (tuple(self.ids), self._uid))
  File "/media/data/dec/projects/12.0/odoo/odoo/sql_db.py", line 154, in wrapper
    return f(self, *args, **kwargs)
  File "/media/data/dec/projects/12.0/odoo/odoo/sql_db.py", line 231, in execute
    res = self._obj.execute(query, params)
psycopg2.errors.SyntaxError: syntax error at or near ")"
LINE 1: SELECT id FROM overdue_reminder_step WHERE id IN () AND crea...

bhaveshselarka · 2020-12-30T03:50:04Z

@alexis-via any chance to merge in main branch ? Thanks for this great module.

alexis-via · 2021-02-10T17:17:04Z

@ypapouin Strange... I don't see why you would have an ir.attachment on overdue.reminder.step. I don't see anywhere in the code where I would create an attachment on overdue.reminder.step.

ypapouin · 2021-03-25T15:21:35Z

account_invoice_overdue_reminder/models/account_invoice.py

+    @api.depends('type', 'state', 'date_due')
+    def _compute_overdue(self):
+        today = fields.Date.context_today(self)
+        for inv in self:


Suggested change

for inv in self:

for inv in self.filtered('date_due'):

Because inv.date_due < today will fail if date_due is False

I wasn't aware that date_due could be False on an open invoice. When does it happen ?

When property_payment_term_id is not set on a partner, it is not filled when a new invoice in created so no date_due.

I'm sorry, but that's not true. When the payment term is empty, date_due = date_invoice. Here is the relevant code in the account module: https://github.com/odoo/odoo/blob/12.0/addons/account/models/account_invoice.py#L1287

Indeed you are right, the problem comes from open invoices created in OpenERP 6.1 before the migration.
Sorry for the buzz.

mrcast

Functional test ok

eLBati · 2021-03-30T12:11:43Z

Hi @alexis-via thanks for this!
Are you aware of any change still to be done, or this could be merged?

alexis-via · 2021-03-30T12:30:36Z

@eLBati it's ready to merge, of course. And also for the other versions.

eLBati · 2021-03-30T12:40:49Z

@OCA/accounting-maintainers could you merge? Thanks

kittiu · 2021-03-30T16:28:18Z

/ocabot merge nobump

OCA-git-bot · 2021-03-30T16:28:47Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-69-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot · 2021-03-30T16:58:29Z

Congratulations, your PR was merged at 3609369. Thanks a lot for contributing to OCA. ❤️

alexis-via force-pushed the 12-add-overdue_reminder branch from 6be2747 to 49f3c7e Compare June 15, 2020 19:37

Add module account_invoice_overdue_reminder

ba70743

alexis-via force-pushed the 12-add-overdue_reminder branch from 49f3c7e to ba70743 Compare June 15, 2020 19:41

Switch row and col in pivot view of overdue reminders

ca5790b

overdue_reminder: explicit error when email is missing

95c0005

ps-tubtim reviewed Jul 22, 2020

View reviewed changes

Saran440 approved these changes Aug 10, 2020

View reviewed changes

This was referenced Aug 17, 2020

[RFC] Module account_invoice_overdue_reminder #87

Closed

[12.0][ADD] hr_expense_advance_overdue_reminder OCA/hr#870

Closed

alexis-via added 2 commits September 12, 2020 01:12

[FIX] overdue_reminder: don't link mail.template to a wizard record !

9b909e5

overdue_reminder: use form_view_ref to display customer invoice form …

d0aec11

…instead of supplier invoice form

oreju pushed a commit to archeti-org/credit-control that referenced this pull request Oct 7, 2020

[#10094][ADD] account_invoice_overdue_reminder - Added module from PR O…

1e6a8b5

…CA#69 : - It added in our fork because in this time was not merged in OCA.

Saran440 mentioned this pull request Oct 12, 2020

[13.0][ADD] base_overdue_reminder OCA/server-ux#219

Closed

alexis-via added 3 commits November 12, 2020 23:55

Add migration script for my previous commit

9b9e76a

ypapouin reviewed Nov 24, 2020

View reviewed changes

account_invoice_overdue_reminder/models/company.py Outdated Show resolved Hide resolved

ypapouin reviewed Nov 24, 2020

View reviewed changes

account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py Outdated Show resolved Hide resolved

ypapouin added a commit to decgroupe/credit-control that referenced this pull request Nov 24, 2020

French translation (OCA#69)

9dbcbd5

ypapouin added a commit to decgroupe/credit-control that referenced this pull request Nov 24, 2020

French translation (OCA#69)

d45fd22

Alexis de Lattre and others added 2 commits November 24, 2020 15:44

Improve string and fix translation of selection field

8c5b529

Co-authored-by: ypapouin <y.papouin@dec-industrie.com>

Fix translation of selection field

808f860

Co-authored-by: ypapouin <y.papouin@dec-industrie.com>

marcelsavegnago approved these changes Nov 24, 2020

View reviewed changes

OCA-git-bot added the approved label Nov 24, 2020

ypapouin approved these changes Nov 25, 2020

View reviewed changes

ps-tubtim approved these changes Dec 3, 2020

View reviewed changes

ypapouin mentioned this pull request Dec 11, 2020

[12.0][FIX] _filter_access_rules fail for empty transient recordset odoo/odoo#63230

Closed

ypapouin reviewed Mar 25, 2021

View reviewed changes

mrcast approved these changes Mar 26, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 30, 2021

OCA-git-bot merged commit 4f27472 into OCA:12.0 Mar 30, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 30, 2021

ypapouin added a commit to decgroupe/credit-control that referenced this pull request Jul 10, 2021

French translation (OCA#69)

b849a24

ypapouin added a commit to decgroupe/credit-control that referenced this pull request Jul 10, 2021

French translation (OCA#69)

9d2da06

alexis-via mentioned this pull request Apr 4, 2022

[12.0][FIX] account_invoice_overdue_reminder: remove mig script 12.0.2.0.0 #180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0] Add module account_invoice_overdue_reminder #69

[12.0] Add module account_invoice_overdue_reminder #69

alexis-via commented Jun 15, 2020

alexis-via commented Jun 15, 2020

alexis-via commented Jun 22, 2020

ps-tubtim Jul 22, 2020

alexis-via Jul 22, 2020

ps-tubtim Jul 23, 2020

bealdav Aug 21, 2020

ps-tubtim Jul 22, 2020

Saran440 left a comment •

edited

Loading

Saran440 Aug 10, 2020

bealdav Aug 21, 2020

alexis-via Nov 24, 2020

Saran440 Aug 10, 2020

bealdav Aug 21, 2020

alexis-via Nov 24, 2020

bealdav commented Aug 21, 2020

alexis-via commented Nov 24, 2020

marcelsavegnago left a comment

ypapouin left a comment

ypapouin commented Dec 11, 2020

bhaveshselarka commented Dec 30, 2020

alexis-via commented Feb 10, 2021

ypapouin Mar 25, 2021

alexis-via Mar 25, 2021

ypapouin Mar 25, 2021

alexis-via Mar 25, 2021

ypapouin Mar 25, 2021

mrcast left a comment

eLBati commented Mar 30, 2021

alexis-via commented Mar 30, 2021

eLBati commented Mar 30, 2021

kittiu commented Mar 30, 2021

OCA-git-bot commented Mar 30, 2021

OCA-git-bot commented Mar 30, 2021

	name = _('%s Reminder %d') % (rec.invoice_id.number, rec.counter)
	name = _("{} Reminder {}".format(rec.invoice_id.number, rec.counter))

		name = _('%s, Reminder %s') % (
		action.commercial_partner_id.display_name, action.date)

	name = _('%s, Reminder %s') % (
	action.commercial_partner_id.display_name, action.date)
	name = _("{}, Reminder {}".format(action.commercial_partner_id.display_name, action.date))

		<odoo noupdate="1">


		<record id="voicemail" model="overdue.reminder.result">

[12.0] Add module account_invoice_overdue_reminder #69

[12.0] Add module account_invoice_overdue_reminder #69

Conversation

alexis-via commented Jun 15, 2020

alexis-via commented Jun 15, 2020

alexis-via commented Jun 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Saran440 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bealdav commented Aug 21, 2020

alexis-via commented Nov 24, 2020

marcelsavegnago left a comment

Choose a reason for hiding this comment

ypapouin left a comment

Choose a reason for hiding this comment

ypapouin commented Dec 11, 2020

bhaveshselarka commented Dec 30, 2020

alexis-via commented Feb 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrcast left a comment

Choose a reason for hiding this comment

eLBati commented Mar 30, 2021

alexis-via commented Mar 30, 2021

eLBati commented Mar 30, 2021

kittiu commented Mar 30, 2021

OCA-git-bot commented Mar 30, 2021

OCA-git-bot commented Mar 30, 2021

Saran440 left a comment •

edited

Loading