-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.0 [MIG] crm_deduplicate_acl migration #122
Conversation
Check Travis error:
|
return super(BasePartnerMergeAutomaticWizard, self)._merge( | ||
self.env.cr, | ||
SUPERUSER_ID if group_unrestricted.id in self.env.user.groups_id | ||
.ids else self.env.uid, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should use self.env.user.has_group
instead.
39039a7
to
0b8ced2
Compare
This module allows any user to get special permissions to be able to deduplicate contacts, instead of just giving them to a sale manager with settings permissions. The new permissions allow the user to deduplicate: - *Manually*. - *Automatically* (dangerous). - *Without restrictions* (more dangerous). Beware what you do! 😯
…ers from the partner list views (action 'Merge automatically') Use <record id="crm.action_partner_merge"... to change only affected field.
6b08d00
to
b5f607d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@cubells one question, where is the functionality of "deduplicate" in v9? in which menu? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cubells one question, where is the functionality of "deduplicate" in v9? in which menu? thanks
v8.0 menu doesn't exist in version 9.0. Module now only inherits wizard to merge partner. |
I think we should recover this menu item. This is a functionality that without this menu item lost a lot. |
I can create a new menu if you want, as the parent menu of version 8.0 has disappear in v.9.0. @pedrobaeza @yajo what do you think? |
Sorry Rafa: menu disappear in crm module. I think It's better do a PR in crm module: https://github.com/OCA/OCB/blob/8.0/addons/crm/base_partner_merge_view.xml#L16 |
I agree @cubells with a PR to CRM module. Let see what @pedrobaeza thinks about this |
It was removed here odoo/odoo@30a7ef8#diff-be356a586330623cb55dac5cdf755b17L15 without apparent reason. I have asked if Odoo would accept a PR amending this in a commit that fixes some things of that commit: odoo/odoo@876634b. If not, we should add here that menu, and depend on this one for other modules that improves deduplication wizard features (like crm_deduplicate_by_website or crm_deduplicate_filter). |
Please include the menu as there's no answer. |
2a6b201
to
8ea7187
Compare
No description provided.