Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 [MIG] crm_deduplicate_acl migration #122

Merged
merged 8 commits into from
Dec 6, 2016

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Nov 7, 2016

No description provided.

@pedrobaeza
Copy link
Member

Check Travis error:

crm_deduplicate_acl/wizards/partner_merge.py:22:29: E131 continuation line unaligned for hanging indent

return super(BasePartnerMergeAutomaticWizard, self)._merge(
self.env.cr,
SUPERUSER_ID if group_unrestricted.id in self.env.user.groups_id
.ids else self.env.uid,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use self.env.user.has_group instead.

yajo and others added 7 commits November 29, 2016 01:50
This module allows any user to get special permissions to be able to
deduplicate contacts, instead of just giving them to a sale manager with
settings permissions.

The new permissions allow the user to deduplicate:

- *Manually*.
- *Automatically* (dangerous).
- *Without restrictions* (more dangerous).

Beware what you do! 😯
…ers from the partner list views (action 'Merge automatically')

Use <record id="crm.action_partner_merge"... to change only affected field.
@rafaelbn rafaelbn added this to the 9.0 milestone Nov 29, 2016
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rafaelbn
Copy link
Member

@cubells one question, where is the functionality of "deduplicate" in v9? in which menu? thanks

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells one question, where is the functionality of "deduplicate" in v9? in which menu? thanks

@cubells
Copy link
Sponsor Member Author

cubells commented Nov 30, 2016

v8.0 menu doesn't exist in version 9.0.

Module now only inherits wizard to merge partner.

@rafaelbn
Copy link
Member

I think we should recover this menu item. This is a functionality that without this menu item lost a lot.

@cubells
Copy link
Sponsor Member Author

cubells commented Nov 30, 2016

I can create a new menu if you want, as the parent menu of version 8.0 has disappear in v.9.0.

@pedrobaeza @yajo what do you think?

@cubells
Copy link
Sponsor Member Author

cubells commented Nov 30, 2016

Sorry Rafa: menu disappear in crm module. I think It's better do a PR in crm module:

https://github.com/OCA/OCB/blob/8.0/addons/crm/base_partner_merge_view.xml#L16

@rafaelbn
Copy link
Member

I agree @cubells with a PR to CRM module. Let see what @pedrobaeza thinks about this

@pedrobaeza
Copy link
Member

It was removed here odoo/odoo@30a7ef8#diff-be356a586330623cb55dac5cdf755b17L15 without apparent reason. I have asked if Odoo would accept a PR amending this in a commit that fixes some things of that commit: odoo/odoo@876634b.

If not, we should add here that menu, and depend on this one for other modules that improves deduplication wizard features (like crm_deduplicate_by_website or crm_deduplicate_filter).

@pedrobaeza
Copy link
Member

Please include the menu as there's no answer.

@pedrobaeza pedrobaeza dismissed rafaelbn’s stale review December 6, 2016 10:45

Menu has been already added

@pedrobaeza pedrobaeza merged commit 82c65c3 into OCA:9.0 Dec 6, 2016
@pedrobaeza pedrobaeza deleted the 9.0-mig-crm_deduplicate_acl branch December 6, 2016 10:46
@pedrobaeza pedrobaeza mentioned this pull request Mar 24, 2017
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants