Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][MIG] crm_phonecall_summary_predefined module #132

Merged
merged 3 commits into from
May 11, 2017

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Jan 31, 2017

  • Updated views
  • Updated README

WIP until:

cc @Tecnativa

yajo and others added 2 commits January 30, 2017 22:55
This module fills the gap of phone marketing companies where phone call summaries can only belong to a limited amount of possibilities.
@cubells cubells force-pushed the 9.0-mig-crm_phonecall_summary_predefined branch from 19aaa19 to e33c199 Compare January 31, 2017 04:21
summary._auto_init(cr, context)

# Proper default value per row
self._init_summary_id(cr, SUPERUSER_ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done as a post_init_hook, not with this hacky technique from old times.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells this is not fixed

@rafaelbn
Copy link
Member

Please @cubells could you review travis? thanks

@rafaelbn rafaelbn added this to the 9.0 milestone Feb 27, 2017
@cubells
Copy link
Sponsor Member Author

cubells commented Feb 27, 2017

@rafaelbn
Travis error is due to crm_phonecall dependency.

We have to wait until #131 was merged.

@cubells cubells force-pushed the 9.0-mig-crm_phonecall_summary_predefined branch from e33c199 to ca9c0c7 Compare March 24, 2017 14:53
@pedrobaeza
Copy link
Member

@cubells please fix this one.

@pedrobaeza pedrobaeza mentioned this pull request Mar 24, 2017
22 tasks
@cubells cubells force-pushed the 9.0-mig-crm_phonecall_summary_predefined branch 3 times, most recently from ba4a9b9 to 0f8fa8b Compare March 28, 2017 18:28
@rafaelbn
Copy link
Member

Please @cubells could you review this PR for testing

@pedrobaeza pedrobaeza force-pushed the 9.0-mig-crm_phonecall_summary_predefined branch 2 times, most recently from 8b06740 to da23cd2 Compare April 1, 2017 14:27
@pedrobaeza
Copy link
Member

@chienandalu @luismontalba this one is ready to be reviewed

=============

To configure the possible summary options, go to:

Copy link
Member

@luismontalba luismontalba Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To configure the possible summary options, activate the developer mode and go to:

To configure the possible summary options, go to:

* Go to *Sales > Configuration > Phone Calls > Summaries*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Go to Sales > Configuration > Sales & Opportunities > Phone calls > Summaries.

Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested on runbot. Please review minor changes proposed in configuration instructions.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality tested on runbot

@cubells cubells force-pushed the 9.0-mig-crm_phonecall_summary_predefined branch 2 times, most recently from 6372d44 to d54bc80 Compare April 3, 2017 09:46
@cubells cubells force-pushed the 9.0-mig-crm_phonecall_summary_predefined branch from d54bc80 to 4eb2b36 Compare May 5, 2017 09:36
@rafaelbn rafaelbn merged commit d1d5bbe into OCA:9.0 May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants