[10.0][MIG] crm_deduplicate_acl #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module allows any user to get special permissions to be able to deduplicate contacts, instead of just giving them to a sale manager with settings permissions. The new permissions allow the user to deduplicate: - *Manually*. - *Automatically* (dangerous). - *Without restrictions* (more dangerous). Beware what you do! 😯
…ers from the partner list views (action 'Merge automatically') Use <record id="crm.action_partner_merge"... to change only affected field.
chienandalu
reviewed
May 30, 2017
crm_deduplicate_acl/__manifest__.py
Outdated
| { | ||
| "name": "Deduplicate Contacts ACL", | ||
| "summary": "Contact deduplication with fine-grained permission control", | ||
| "version": "10.0.1.1.0", |
pedrobaeza
requested changes
May 30, 2017
crm_deduplicate_acl/README.rst
Outdated
| Known issues / Roadmap | ||
| ====================== | ||
|
|
||
| * Wizard's code is partially written in old API because somehow [possibly] |
There was a problem hiding this comment.
This known issue is not true now.
crm_deduplicate_acl/__manifest__.py
Outdated
| { | ||
| "name": "Deduplicate Contacts ACL", | ||
| "summary": "Contact deduplication with fine-grained permission control", | ||
| "version": "10.0.1.1.0", |
| raise UserError(_("All contacts must have the same email." | ||
| " Only the Administrator can merge contacts" | ||
| " with different emails.")) | ||
|
|
There was a problem hiding this comment.
Don't add these extra lines (in any case 2, but not also 1 in the middle of the method)
| src_partners = ordered_partners[:-1] | ||
| _logger.info("dst_partner: %s", dst_partner.id) | ||
|
|
||
| # FIXME: is it still required to make and exception for |
There was a problem hiding this comment.
Please check if this is needed, and if not, remove it.
There was a problem hiding this comment.
It is still commented in V10:
https://github.com/odoo/odoo/blob/4b102523b584a5383009f2e19b6f7d0c07c61591/addons/crm/wizard/base_partner_merge.py#L321
chienandalu
suggested changes
May 31, 2017
| child_ids = self.env['res.partner'] | ||
| for partner_id in partner_ids: | ||
| child_ids |= Partner.search([('id', 'child_of', [partner_id.id])])\ | ||
| - partner_id |
There was a problem hiding this comment.
this indentation is making your lint checks fail
pedrobaeza
approved these changes
Jun 6, 2017
|
@chienandalu please give final review |
chienandalu
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate Contacts ACL
This module extends the functionality of the CRM contact deduplicator to add
permission groups that allow the matching users to use those tools, not
needing to be the sale settings manager.
Configuration
To configure this module, you need to:
Go to Settings > Users > Users.
Choose a user.
Choose the desired permission level(s) in Appplication > Deduplicate
Contacts:
rigts, to be able to update objects where the user would normally not have
write rights, and to allow him to merge contacts with different email
addresses.
Usage
To use this module, you need to:
#. Ask your admin to give you the new rights.
#. Go to CRM > Tools > Deduplicate Contacts as usual.
cc @Tecnativa