[ADD] add crm_lead_lost_reason addon

[rdeheele]

Add opportunity_lost_reason addon (sale_cancel_reason clone)

[pedrobaeza]

Extract to README.rst.

[pedrobaeza]

Please call the module crm_lead_lost_reason, to be technically coherent, although you put on the description the word "Opportunity".

[dreispt]

Isn't this already implemented on sale_cancel_reason?

[pedrobaeza]

As I can see, it's not the same part of the sales flow: one is in the opportunity, the other on the sale order.

[dreispt]

OK

[rdeheele]

@pedrobaeza agree with you to rename the module.
it's work in progress because I see now 2 ways to avoid providing a lost reason:

• via kanban view
• via tree view and the button "More".

[coveralls]

Coverage remained the same at 95.65% when pulling 2285e8b on rdeheele:opportunity_lost_reason into 67970e8 on OCA:8.0.

[rdeheele]

@pedrobaeza @dreispt @yvaucher feedbacks are welcome.
In the last commit, on kanban/list views, we force the users to pass by form to mark as lost an opportunity (a warning is raised to inform about it) : it avoids struggling with javascript kanban view code.

[pedrobaeza]

Well, check the stage by name is not the best option, and it can be conflicted also with languages. There isn't any other option?

[rdeheele]

gaah..there are 4 ways to mark lost an opportunity (via more button on list view, via drag and drop on kanban view, via click on statusbar on form view and ... via the button "Mark Lost" on form)

[coveralls]

Coverage remained the same at 93.75% when pulling 5d88be3 on rdeheele:opportunity_lost_reason into 67970e8 on OCA:8.0.

[coveralls]

Coverage remained the same at 93.75% when pulling 0ffa89c on rdeheele:opportunity_lost_reason into 67970e8 on OCA:8.0.

[rdeheele]

there are multiple ways to set "Lost" a lead (more button on list view, drag and drop on kanban view,click on statusbar on form view and the red button "Mark Lost" on form), for now this addon forces the user to use the red button "Mark Lost" on form : this is the only way where it's easy (i.e. without dealing with javascript) to display a pop-up wizard for the user to indicate a lost reason.

[pedrobaeza]

Well, it's not perfect, but it can work. Please put this on README file under section Known issues / Roadmap. Also OCA's template would be advisable.

[jgrandguillaume]

Hi,

Thanks for the contrib ! +1 to have the OCA template. Otherwise LGTM 👍

Regards,

[gurneyalex]

this needs to be a .rst file. Just renaming should be ok

[dreispt]

@gurneyalex afaik markdown is allowed.

[pedrobaeza]

No, not really, they are read, but not correctly parsed. They are parsed as RestructuredText (RST). So better to put .rst so GitHub parses OK also.

[gurneyalex]

missing .pot file

[coveralls]

Coverage remained the same at 93.75% when pulling c89ed8d on rdeheele:opportunity_lost_reason into 67970e8 on OCA:8.0.

[coveralls]

Coverage remained the same at 93.75% when pulling c89ed8d on rdeheele:opportunity_lost_reason into 67970e8 on OCA:8.0.

[pedrobaeza]

Thanks 👍 if Travis goes well.

[coveralls]

Coverage remained the same at 93.75% when pulling c89ed8d on rdeheele:opportunity_lost_reason into 67970e8 on OCA:8.0.