Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] crm_claim: Migration to 11.0 #184

Merged
merged 3 commits into from
Dec 13, 2017
Merged

[11.0][MIG] crm_claim: Migration to 11.0 #184

merged 3 commits into from
Dec 13, 2017

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Oct 31, 2017

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Oct 31, 2017
Closed
28 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
@pedrobaeza
Copy link
Member

Please check Travis

@oihane
Copy link
Contributor Author

oihane commented Nov 1, 2017

@pedrobaeza Travis fixed
I did some changes in menus, here you have an image of them:
fireshot capture 8 - claims - odoo_ - http___127 0 0 1_9169_web view_type

pedrobaeza
pedrobaeza approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells please review

cubells
cubells approved these changes Nov 2, 2017
View reviewed changes
Copy link
Sponsor Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

code review and tests

yajo
yajo approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code ok

@anajuaristi
Copy link

anajuaristi commented Nov 16, 2017 •
edited
Loading

Buenas... hoy hemos visto que no funciona o no existe el onchange en el campo "categoría de claim", donde se identifica el equipo que tiene que resolverlo.
Al seleccionar una categoría de claim debería traer el equipo de dicha categoría al campo correspondiente.

Es una mejora que creo que deberíamos incorporar.

Ya direis.

@oihane
Copy link
Contributor Author

oihane commented Nov 16, 2017 •
edited
Loading

From an usability point of view, to do that category field should be relocated.

fireshot capture 724 - nuevo - odoo_ - http___ce avanzosc es_web

@cubells
Copy link
Sponsor Member

cubells commented Nov 19, 2017

@anajuaristi +1 to set sales team on update category claim...

@oihane
Copy link
Contributor Author

oihane commented Dec 13, 2017

Finally and after a chat with @pedrobaeza I have changed the view and I have added the onchange asked by @anajuaristi and @cubells
fireshot capture 752 - damaged products - odoo_ - http___192 168 1 40_9169_web id 2

@pedrobaeza pedrobaeza merged commit 5f3550c into OCA:11.0 Dec 13, 2017
@oihane oihane deleted the 11.0-mig-crm_claim branch December 13, 2017 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

@cubells cubells cubells approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oihane @pedrobaeza @anajuaristi @cubells @yajo