Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] crm_helpdesk #225

Merged
merged 4 commits into from
Jul 18, 2020
Merged

[11.0][MIG] crm_helpdesk #225

merged 4 commits into from
Jul 18, 2020

Conversation

MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Sep 14, 2018 •
edited
Loading

Standard migration of #166.

@pedrobaeza
Copy link
Member

Do you know @DarioLodeiros's work on this?

@MiquelRForgeFlow
Copy link
Contributor Author

Do you know @DarioLodeiros's work on this?

No.

@pedrobaeza
Copy link
Member

Discussion in OCA/project#391 and PR in OCA/project#394

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 11.0-mig-crm_helpdesk branch 2 times, most recently from 2653520 to b7c11b7 Compare September 14, 2018 17:02
@MiquelRForgeFlow
Copy link
Contributor Author

Good to know, thanks. I will look.

@DarioLodeiros
Copy link
Member

Hi! Next week I return from vacations and I update the project state ;)

@JordiBForgeFlow
Copy link
Sponsor Member

@mreficent @DarioLodeiros it will be great if we can converge to a great helpdesk solution!

@DarioLodeiros
Copy link
Member

Yeah!
If you want, We could do a hang session next week to review what was done and prepare tasks for a first version. :D

@JordiBForgeFlow JordiBForgeFlow mentioned this pull request Sep 19, 2018
Closed
@DarioLodeiros
Copy link
Member

I do not know the basic features to migrate, could you give me guidance about those that are still in WIP?

@JordiBForgeFlow
Copy link
Sponsor Member

@DarioLodeiros I think that it would be interesting to look at what this PR provides, and then what you have in mind and we can create an Issue with the ideas around the roadmap.

But I am not sure what is in WIP from your PoV

@DarioLodeiros DarioLodeiros mentioned this pull request Sep 21, 2018
Closed
6 tasks
@DarioLodeiros
Copy link
Member

DarioLodeiros commented Sep 21, 2018 •
edited
Loading

@jbeficent, I mean if the PR is ready to do the merge or @mreficent is still working on something (in the description it puts WIP). I have tried the basic functions in runbot and I found it ok from my PoV. If you are ok, @pedrobaeza , can you make merge? (or... if you view the next proposal... maybe wait to make the first point?, I dont know)
I create this issue for design and proposal discusion, based on this own PR: #229
If you give me your approval to those characteristics I start work ... ah!, and better if we already have this merged PR in 11, @pedrobaeza?
Thanks!

@pedrobaeza pedrobaeza added this to the 11.0 milestone Sep 21, 2018
pedrobaeza
pedrobaeza previously requested changes Sep 21, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And don't depend on sale if not needed.

crm_helpdesk/report/crm_helpdesk_report_view.xml Outdated Show resolved Hide resolved
crm_helpdesk/views/crm_helpdesk_menu.xml Outdated Show resolved Hide resolved
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Sep 21, 2018 •
edited
Loading

@DarioLodeiros I removed the WIP (I was waiting @pedrobaeza review 😜). Now it's ready 🍏

@DarioLodeiros
Copy link
Member

Perfect!!
Whats your opinion about #229 ?? If you can comment on issue it help me to guide the next step ;)
Thanks!

@oca-clabot

This comment has been minimized.

Sign in to view
@oca-clabot

This comment has been minimized.

Sign in to view
@oca-clabot

This comment has been minimized.

Sign in to view
HviorForgeFlow
HviorForgeFlow approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HviorForgeFlow
Copy link
Member

@pedrobaeza it seems that request changes have already been taken into account. Can it be moved forward? Thanks,

@pedrobaeza pedrobaeza dismissed their stale review April 12, 2019 09:25

No deep review

@pedrobaeza
Copy link
Member

OK, I have dismissed my review for not blocking, but not able to fully review it.

@HviorForgeFlow
Copy link
Member

@jbeficent can you review?

AdriaGForgeFlow
AdriaGForgeFlow approved these changes Jul 29, 2019
View reviewed changes
Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 👍

@pedrobaeza
Copy link
Member

Have you checked new helpdesk solution in https://github.com/OCA/helpdesk?

@dreispt
Copy link
Sponsor Member

dreispt commented Jul 18, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-225-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aede72c into OCA:11.0 Jul 18, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4ea44df. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago
Copy link
Sponsor Member

marcelsavegnago commented Jul 18, 2020 •
edited
Loading

Have you checked new helpdesk solution in https://github.com/OCA/helpdesk?

Despite the great work, I believe that for version 12 and the next it is better to consider maintaining efforts on the project https://github.com/OCA/helpdesk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarioLodeiros DarioLodeiros DarioLodeiros approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

@pedrobaeza pedrobaeza pedrobaeza left review comments

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@MiquelRForgeFlow @pedrobaeza @DarioLodeiros @JordiBForgeFlow @oca-clabot @HviorForgeFlow @dreispt @OCA-git-bot @marcelsavegnago @AdriaGForgeFlow