-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][ADD] crm_lead_product #245
Conversation
c8bdeb8
to
28c8eab
Compare
28c8eab
to
6a46641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
cc @aheficent @hveficent can you review? @rafaelbn I think that you'll like this one. We'll backport to 11.0 after it's merged in 12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Functional review on runbot
This PR has the |
@ageficent Please squash and I'll merge. |
486fb7e
to
8a46252
Compare
Done 👍 |
If possible and in budget please could you increase a little bit coverage? This repo /crm is very well maintained 😄 codecov/patch — 53.64% of diff hit (target 97.53%) |
Your review if the module and we'll increase!! :)
El mié., 16 ene. 2019 22:51, Rafael Blasco <notifications@github.com>
escribió:
… If possible and in budget please could you increase a little bit coverage?
This repo /crm is very well maintained 😄
codecov/patch — 53.64% of diff hit (target 97.53%)
codecov/project — 78.81% (-18.73%) compared to 641b4af
<641b4af>
[image: 2019-01-16_22-48-38]
<https://user-images.githubusercontent.com/8736623/51280872-1d372500-19e1-11e9-853f-37d53a0748c5.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#245 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AHU_VvQYVQrgoLg8hxRkHBhS_ravZY92ks5vD57QgaJpZM4Y3HhE>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionaly 👍
Just some minor comments non-blocking 😄
Hello @ageficent , travis is now in 🔴 |
ebaf0ae
to
766603f
Compare
add filter for open opportunities in pipeline by product report [IMP] Extend test coverage
766603f
to
0e34ef6
Compare
Green again 🍏 |
Add a new module crm_lead_product which allows a user to link multiple products, product categories or product templates to a lead or an opportunity in order to be able to do a product demand forecasting taking into account the leads and opportunities defined in odoo.