Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][ADD] crm_lead_product #245

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Conversation

AdriaGForgeFlow
Copy link

Add a new module crm_lead_product which allows a user to link multiple products, product categories or product templates to a lead or an opportunity in order to be able to do a product demand forecasting taking into account the leads and opportunities defined in odoo.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 28, 2018
@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 12.0-add-crm_lead_product branch 4 times, most recently from c8bdeb8 to 28c8eab Compare November 28, 2018 10:27
Copy link
Sponsor Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@JordiBForgeFlow
Copy link
Sponsor Member

cc @aheficent @hveficent can you review?

@rafaelbn I think that you'll like this one. We'll backport to 11.0 after it's merged in 12.0

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional review on runbot

crm_lead_product/README.rst Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow
Copy link
Sponsor Member

@ageficent Please squash and I'll merge.

@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 12.0-add-crm_lead_product branch 2 times, most recently from 486fb7e to 8a46252 Compare January 16, 2019 07:52
@AdriaGForgeFlow
Copy link
Author

@ageficent Please squash and I'll merge.

Done 👍

@rafaelbn
Copy link
Member

If possible and in budget please could you increase a little bit coverage? This repo /crm is very well maintained 😄

codecov/patch — 53.64% of diff hit (target 97.53%)
codecov/project — 78.81% (-18.73%) compared to 641b4af

2019-01-16_22-48-38

@JordiBForgeFlow
Copy link
Sponsor Member

JordiBForgeFlow commented Jan 16, 2019 via email

@rafaelbn
Copy link
Member

Tested in runbot 👍

Maybe you could explain in README which is the difference between "planned revenue" and "expected revenue"

Just UX check this:

2019-01-17_0-25-22

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionaly 👍

Just some minor comments non-blocking 😄

@rafaelbn
Copy link
Member

Hello @ageficent , travis is now in 🔴

@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 12.0-add-crm_lead_product branch 3 times, most recently from ebaf0ae to 766603f Compare January 18, 2019 08:04
add filter for open opportunities in pipeline by product report

[IMP] Extend test coverage
@AdriaGForgeFlow
Copy link
Author

Hello @ageficent , travis is now in

Green again 🍏

@rafaelbn rafaelbn merged commit 3330d34 into OCA:12.0 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants