Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] crm_phonecall_summary_predefined #252

Merged
merged 8 commits into from Apr 16, 2019
Merged

[12.0] [MIG] crm_phonecall_summary_predefined #252

merged 8 commits into from Apr 16, 2019

Conversation

anandkansagra
Copy link
Member

Issue Reference

@anandkansagra anandkansagra mentioned this pull request Dec 22, 2018
Closed
20 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 22, 2018
@pedrobaeza
Copy link
Member

Please squash together adjacent "[UPD] Update crm_phonecall_summary_predefined.pot" commits and check runbot status.

@anandkansagra anandkansagra force-pushed the 12.0-mig-crm_phonecall_summary_predefined branch from 906b30d to b6898b7 Compare December 22, 2018 13:01
@anandkansagra
Copy link
Member Author

anandkansagra commented Dec 22, 2018 •
edited

Please squash together adjacent "[UPD] Update crm_phonecall_summary_predefined.pot"

Done

check runbot status.

Well regarding that, took a pull from the remote 12.0 branch which has crm_phonecall module. In the runbot log, couldn't find why it has not passed. Could you help me with that thing?

@anandkansagra
Copy link
Member Author

Well regarding that, took a pull from the remote 12.0 branch which has crm_phonecall module. In the runbot log, couldn't find why it has not passed. Could you help me with that thing?

Fixed

tbaden
tbaden suggested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandkansagra thanks for your work.
I did a code review and here are some minor changes:

crm_phonecall_summary_predefined/__manifest__.py Outdated Show resolved Hide resolved
crm_phonecall_summary_predefined/views/crm_phonecall_summary_view.xml Outdated Show resolved Hide resolved
crm_phonecall_summary_predefined/views/crm_phonecall_summary_view.xml Outdated Show resolved Hide resolved
crm_phonecall_summary_predefined/views/crm_phonecall_summary_view.xml Outdated Show resolved Hide resolved
crm_phonecall_summary_predefined/views/crm_phonecall_summary_view.xml Outdated Show resolved Hide resolved
crm_phonecall_summary_predefined/views/crm_phonecall_summary_view.xml Outdated Show resolved Hide resolved
crm_phonecall_summary_predefined/views/crm_phonecall_summary_view.xml Outdated Show resolved Hide resolved
@anandkansagra
Copy link
Member Author

@anandkansagra thanks for your work.
I did a code review and here are some minor changes:

@tbaden ,
I have made the changes.

tbaden
tbaden approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

@pedrobaeza pedrobaeza force-pushed the 12.0-mig-crm_phonecall_summary_predefined branch from 0785735 to bd3a5ec Compare April 16, 2019 11:25
@pedrobaeza pedrobaeza merged commit 0d3f8c3 into OCA:12.0 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@anandkansagra @pedrobaeza @tbaden @OCA-git-bot @yajo @oca-transbot @cubells @oca-travis @cristinamartinrod